fix #1579: getCacheVersion mutates arguments#1587
Closed
Smeb wants to merge 1 commit intoactions:mainfrom
Closed
Conversation
Contributor
Author
|
It would be great to get this addressed as we use this internally. From my side linting and checks are passing. |
BrandonLWhite
approved these changes
Dec 18, 2023
ramblingenzyme
approved these changes
Mar 1, 2024
bethanyj28
approved these changes
Mar 1, 2024
Contributor
bethanyj28
left a comment
bethanyj28
left a comment
There was a problem hiding this comment.
Thanks for the contribution! LGTM
Contributor
|
Actually seeing this was fixed in #1378 - so going to close. Thank you! |
Contributor
Author
|
Ok - what about including the tes - I see the fix in #1378 does not add any tests? I can modify this patch in that case. |
Contributor
|
@Smeb - keeping the test would be fantastic! That would be a big help 🙏🏻 Feel free to re-open and tag me when it's ready. |
|
@bethanyj28 can we get #1579 closed off as fixed too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into the issue described in #1579, this fixes it.