Skip to content

Conversation

@GhadimiR
Copy link
Contributor

These are only returned in exceptional situations, it's better to not slow down the run retrying these when cache is best effort.

Copilot AI review requested due to automatic review settings January 16, 2026 09:50
@GhadimiR GhadimiR requested a review from a team as a code owner January 16, 2026 09:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modifies the cache service client to stop retrying 429 (Too Many Requests) responses from the cache service. Previously, 429s were treated as retryable errors, but this change makes them fail immediately to prevent slowing down runs since cache is a best-effort service.

Changes:

  • Removed HttpCodes.TooManyRequests from the list of retryable status codes
  • Added special handling for 429 responses to warn users about rate limits and throw immediately
  • Added comprehensive test coverage for the new 429 handling behavior

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
packages/cache/src/internal/shared/cacheTwirpClient.ts Removed 429 from retryable status codes and added special handling to detect retry-after headers and warn users before throwing
packages/cache/tests/cacheTwirpClient.test.ts Added comprehensive tests validating that 429s fail immediately without retries and properly handle retry-after headers
packages/cache/package.json Bumped version from 5.0.2 to 5.0.3
packages/cache/RELEASES.md Added release notes for 5.0.3

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

GhadimiR and others added 2 commits January 16, 2026 10:25
Co-authored-by: Bassem Dghaidi <568794+Link-@users.noreply.github.com>
Added a comment regarding rate limiting and retry behavior.
@Link-
Copy link
Member

Link- commented Jan 16, 2026

For posterity, we're not retrying on the retry after schedule to prevent workflow run delays. It's best to fail fast in this case. We might want to make this configurable though.

@GhadimiR GhadimiR merged commit ee91adf into actions:main Jan 16, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants