-
Notifications
You must be signed in to change notification settings - Fork 1.7k
upgrade octokit dependencies #2249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request upgrades the octokit dependencies in the @actions/github package from versions 5.x/9.x/10.x/8.x/5.x to 7.x/14.x/17.x/10.x/7.x respectively. The upgrade includes necessary configuration changes to support the new dependency versions and their ESM compatibility requirements.
Changes:
- Upgraded five @octokit packages to their latest major versions
- Added ES2022 library support to TypeScript configuration
- Updated Jest configuration to handle ESM modules from octokit dependencies
- Bumped package version from 7.0.0 to 7.0.1
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/github/package.json | Updated version to 7.0.1 and upgraded all @octokit dependencies to latest major versions |
| packages/github/package-lock.json | Lockfile updated with new dependency versions and transitive dependencies; removed deprecated packages (deprecation, once, wrappy); added fast-content-type-parse |
| tsconfig.json | Added ES2022 to lib array to support new dependency features |
| packages/github/jest.config.js | Enhanced ts-jest configuration with ESM support and added transformIgnorePatterns for octokit packages |
| packages/github/RELEASES.md | Added release notes for version 7.0.1 documenting the octokit dependency upgrades |
Files not reviewed (1)
- packages/github/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
packages/github/package.json:52
- The upgraded octokit dependencies require Node >= 20, but the package.json doesn't specify this requirement in an "engines" field. Consider adding an "engines" field to explicitly document the minimum Node version requirement for users of this package. This will help package managers warn users if they're using an incompatible Node version.
{
"name": "@actions/github",
"version": "7.0.1",
"description": "Actions github lib",
"keywords": [
"github",
"actions"
],
"homepage": "https://github.com/actions/toolkit/tree/main/packages/github",
"license": "MIT",
"main": "lib/github.js",
"types": "lib/github.d.ts",
"directories": {
"lib": "lib",
"test": "__tests__"
},
"files": [
"lib",
"!.DS_Store"
],
"publishConfig": {
"access": "public"
},
"repository": {
"type": "git",
"url": "git+https://github.com/actions/toolkit.git",
"directory": "packages/github"
},
"scripts": {
"audit-moderate": "npm install && npm audit --json --audit-level=moderate > audit.json",
"test": "jest",
"build": "tsc",
"format": "prettier --write **/*.ts",
"format-check": "prettier --check **/*.ts",
"tsc": "tsc"
},
"bugs": {
"url": "https://github.com/actions/toolkit/issues"
},
"dependencies": {
"@actions/http-client": "^3.0.1",
"@octokit/core": "^7.0.6",
"@octokit/plugin-paginate-rest": "^14.0.0",
"@octokit/plugin-rest-endpoint-methods": "^17.0.0",
"@octokit/request": "^10.0.7",
"@octokit/request-error": "^7.1.0",
"undici": "^5.28.5"
},
"devDependencies": {
"proxy": "^2.1.1"
}
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9e24a6c to
f61ae48
Compare
Upgrade octokit depdencies