Skip to content

Conversation

@kiprasmel
Copy link
Contributor

@kiprasmel kiprasmel commented Feb 6, 2020

Inspired by https://github.com/actions/cache/blob/master/src/restore.ts#L30-L33

Would fix #184,

but there's another issue - actions/cache#44:
an input list should use arrays instead of strings,
separated by newlines (\n).

Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
@kiprasmel kiprasmel marked this pull request as ready for review February 6, 2020 22:53
@bryanmacfarlane
Copy link
Member

bryanmacfarlane commented Feb 10, 2020

yeah, I think the real list type would be cooperative with the yaml, the service and come down in the job message to the runner as a line delimited or array of strings.

Thanks so much for the PR but I'm not sure it's the right path. I'll leave open and check with folks.

@kiprasmel
Copy link
Contributor Author

@bryanmacfarlane I agree - let's not rush this.

@KaelWD
Copy link

KaelWD commented Jul 22, 2020

This would be useful for me, I'm trying to upload ignored files as artefacts but actions/upload-artifact doesn't support a newline-delimited string:

- run: echo ::set-env name=GITHUB_ARTIFACTS_LOCATIONS::$(git status --ignored --porcelain | grep -oP '(?!.*node_modules\/.*)\!\! \K.*')
- uses: actions/upload-artifact@v2
  with:
    path: ${{ env.GITHUB_ARTIFACTS_LOCATIONS }}
##[warning]No files were found for the provided path: packages/vuetify/es5/ packages/vuetify/lib-temp/ packages/vuetify/lib/. No artifacts will be uploaded.

@mmagician
Copy link

Any updates on this feature?

@thboop thboop changed the base branch from master to main May 27, 2021 15:13
@thboop thboop requested a review from a team as a code owner May 27, 2021 15:13
@thboop
Copy link
Collaborator

thboop commented Jun 4, 2021

Hey @kiprasmel , thanks for the contribution, I've made some minor updates and created: https://github.com/actions/toolkit/pull/829/files

Going to merge that pr and release a new version this week. Going to close this out in favor of that.

@thboop thboop closed this Jun 4, 2021
@kiprasmel
Copy link
Contributor Author

Hey @thboop, that's great - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support list input type

5 participants