-
Notifications
You must be signed in to change notification settings - Fork 1.7k
core: Create getInputList utility
#336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
|
yeah, I think the real list type would be cooperative with the yaml, the service and come down in the job message to the runner as a line delimited or array of strings. Thanks so much for the PR but I'm not sure it's the right path. I'll leave open and check with folks. |
|
@bryanmacfarlane I agree - let's not rush this. |
|
This would be useful for me, I'm trying to upload ignored files as artefacts but - run: echo ::set-env name=GITHUB_ARTIFACTS_LOCATIONS::$(git status --ignored --porcelain | grep -oP '(?!.*node_modules\/.*)\!\! \K.*')
- uses: actions/upload-artifact@v2
with:
path: ${{ env.GITHUB_ARTIFACTS_LOCATIONS }} |
|
Any updates on this feature? |
|
Hey @kiprasmel , thanks for the contribution, I've made some minor updates and created: https://github.com/actions/toolkit/pull/829/files Going to merge that pr and release a new version this week. Going to close this out in favor of that. |
|
Hey @thboop, that's great - thanks! |
Inspired by https://github.com/actions/cache/blob/master/src/restore.ts#L30-L33
Would fix #184,
but there's another issue - actions/cache#44:
an input list should use arrays instead of strings,
separated by newlines (
\n).