Skip to content

Avoid re-using non-keep-alive "main" HTTP client #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
developit wants to merge 2 commits into from
Closed

Avoid re-using non-keep-alive "main" HTTP client #401

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94f477f
Avoid re-using non-keep-alive "main" HTTP client
developit Apr 2, 2020
f5b52fd
Allocate for i+1 clients
developit Apr 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/artifact/src/internal/upload-http-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export class UploadHttpClient {
private statusReporter: UploadStatusReporter

constructor() {
this.uploadHttpManager = new HttpManager(getUploadFileConcurrency())
this.uploadHttpManager = new HttpManager(getUploadFileConcurrency() + 1)
this.statusReporter = new UploadStatusReporter()
}

Expand Down Expand Up @@ -112,7 +112,8 @@ export class UploadHttpClient {
})
}

const parallelUploads = [...new Array(FILE_CONCURRENCY).keys()]
// http client indices start at 1 to avoid re-using the main client
const parallelUploads = new Array(FILE_CONCURRENCY).fill(0).map((x, i) => i + 1)
const failedItemsToReport: string[] = []
let currentFile = 0
let completedFiles = 0
Expand Down