Add HashFiles to the toolkit #830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thboop
commented
Jun 4, 2021
| core.debug(`Found ${count} files to hash.`) | ||
| return result.digest('hex') | ||
| } else { | ||
| core.error(`No matches found for glob`) |
Collaborator
Author
There was a problem hiding this comment.
what should we do when no files are found?
Contributor
There was a problem hiding this comment.
IMO this feels more like a warning than an error
thboop
commented
Jun 4, 2021
thboop
commented
Jun 4, 2021
luketomlinson
approved these changes
Jun 7, 2021
Contributor
luketomlinson
left a comment
luketomlinson
left a comment
There was a problem hiding this comment.
Looks good! One comment, not a show stopper
| core.debug(`Found ${count} files to hash.`) | ||
| return result.digest('hex') | ||
| } else { | ||
| core.error(`No matches found for glob`) |
Contributor
There was a problem hiding this comment.
IMO this feels more like a warning than an error
|
Hi, I am trying to use this in an action. Could you please publish a new version of this module to NPM? |
This was referenced Aug 6, 2021
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #472