Resolve vulnerabilities found by npm audit
#846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brcrista
commented
Jun 14, 2021
brcrista
commented
Jun 14, 2021
Closed
Contributor
|
Why is the It's introducing quite a bit changes that I think we can avoid |
Contributor
Author
|
@konradpabjan that's probably because I ran |
brcrista
force-pushed
the
brcrista/audit-fix
branch
from
be8c8a7 to
f1ba29d
Compare
konradpabjan
approved these changes
Jun 14, 2021
Contributor
konradpabjan
left a comment
konradpabjan
left a comment
There was a problem hiding this comment.
LGTM! 🚀
@thboop could you confirm if these changes are good
thboop
reviewed
Jun 14, 2021
konradpabjan
approved these changes
Jun 15, 2021
thboop
reviewed
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #845 the workflow https://github.com/actions/toolkit/actions/workflows/audit.yml failed because of some known vulnerabilities.
Most of these I fixed with
npm audit fix. However, thelernapackage, which is a dev dependency, needs to be updated (discussion). Therefore, I'm changing the workflow to run with--production, which excludes dev dependencies.Sample output: