Skip to content

Conversation

@TingluoHuang
Copy link
Member

No description provided.

@TingluoHuang TingluoHuang requested a review from a team as a code owner August 25, 2021 20:40
@TingluoHuang TingluoHuang requested a review from a team August 25, 2021 20:43
@TingluoHuang TingluoHuang force-pushed the users/tihuang/oidcupdate branch from 2a6cdb6 to d7dd89f Compare August 25, 2021 20:47
if (!runtimeUrl) {
throw new Error('Unable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable')
}
return `${runtimeUrl}?api-version=${OidcClient.getApiVersion()}`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACTIONS_ID_TOKEN_REQUEST_URL will include ?api-version=2.0

Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TingluoHuang TingluoHuang merged commit 5c3e1c2 into features/oidcpreview Aug 26, 2021
@TingluoHuang TingluoHuang deleted the users/tihuang/oidcupdate branch August 26, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants