Add --platform to docker run call in Zeek shell script#38
Open
william-stearns wants to merge 4 commits intomasterfrom
Open
Add --platform to docker run call in Zeek shell script#38william-stearns wants to merge 4 commits intomasterfrom
william-stearns wants to merge 4 commits intomasterfrom
Conversation
Contributor
|
I'm just curious if you ran into a case where it failed without this? In my experience, The help for that flag seems to indicate it's for a special case of a multi-platform server. I'm slightly against unnecessary complexity. But if there's a real need for this then it LGTM. |
Contributor
Author
|
I believe we did run into an issue with a customer Pi where docker was
attempting to load the x86_64 image on an arm64 platform. While it's
possible I'm wrong and the source of the problem was somewhere else, Logan
and I felt it contributed to the fix, and if I was wrong, at least it
wouldn't hurt.
…On Thu, Feb 24, 2022 at 10:00 PM ethack ***@***.***> wrote:
I'm just curious if you ran into a case where it failed without this? In
my experience, docker pull will grab the image for the architecture it's
running on, but I haven't done a ton on Pi's with docker.
The help for that flag seems to indicate it's for a special case of a
multi-platform server.
--platform string Set platform if server is multi-platform capable
I'm slightly against unnecessary complexity. But if there's a real need
for this then it LGTM.
—
Reply to this email directly, view it on GitHub
<#38 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA272WMVT25CXKQJZBOF5P3U43WGFANCNFSM5PINOAXA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.