Update adafruit_rockblock.py

[gr3mlin]

Recommend using the CRISX AT command to pull ring alerts because it includes a timestamp field, which will be added to the returned tuple. The timestamp can be monitored to check for recent ring alerts.

[caternuson]

Have you tested this to make sure the parser line doesn't need any updating?

return tuple(resp[1].strip().decode().split(":")[1].split(","))

Seems like it should nominally work since it just splits on the ,. So will now be a 3 tuple instead of a 2 tuple.

[gr3mlin]

I didn't make any changes to the parser line and it's worked as expected, a 3 tuple is returned. I've been running constantly with my branch for the last 4 days without issue. I may provide more commits for a new function as the ability to interrupt on a change of the ring indication timestamp has been tremendously useful for knowing when to contact the satellite to receive new messages cost efficiently.

…

On Thu, Oct 10, 2024 at 10:16 AM Carter Nelson ***@***.***> wrote: Have you tested this to make sure the parser line doesn't need any updating? return tuple(resp[1].strip().decode().split(":")[1].split(",")) Seems like it should nominally work since it just splits on the ,. So will now be a 3 tuple instead of a 2 tuple. image.png (view on web) <https://github.com/user-attachments/assets/eecf90e3-760c-4b29-80ba-42ae197fa904> — Reply to this email directly, view it on GitHub <#31 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH353LRXNYRPYRDSFETGRLZ22D3HAVCNFSM6AAAAABPVH57SSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBVGIYTSMZVHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Respectfully, Michael Weigand 301-351-9476 ***@***.***

[caternuson]

I may provide more commits for a new function as
the ability to interrupt on a change

Please submit that as a separate PR.

For this PR, looks good as is. But please also update the function doc string to cover the new behavior for ring_indication

[gr3mlin]

Will do. I’ll update the comments tonight for review. Respectfully, Michael Weigand 301-351-9476 ***@***.***

…

On Tue, Oct 15, 2024 at 9:15 AM Carter Nelson ***@***.***> wrote: I may provide more commits for a new function as the ability to interrupt on a change Please submit that as a separate PR. For this PR, looks good as is. But please also update the function doc string to cover the new behavior for ring_indication — Reply to this email directly, view it on GitHub <#31 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH353J3AGYZJGT4ZGYW37TZ3UIQHAVCNFSM6AAAAABPVH57SSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJTHA4DQMJSGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[FoamyGuy]

I merged main to this branch and added info to the docstrings about the timestamp field now being returned.

I also made it return a 3-tuple of None instead of 2 when the response is not OK.