Fix zipentry comment implementation #929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 13, 2025
This was referenced Oct 24, 2025
This was referenced Nov 3, 2025
This was referenced Nov 10, 2025
This was referenced Nov 24, 2025
This was referenced Dec 1, 2025
This was referenced Dec 15, 2025
This was referenced Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Commentfield was only present the directory entry header, not the local entry header. This makes some sense as the local entry header does not have a comment in the zip file, but due to the way the local entry header was loaded (replacing the directory entry header with the local entry header) this caused the code expecting a directory entry header to fail once that happened.I've decided to just put the
Commentfield on the underlyingZipFileEntryclass and copy the value from the directory entry header to the local entry header.See the added test for how this failed.