Removed wrappers that weren't needed (probably) #959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/SharpCompress/Compressors/Xz/XZIndex.cs
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes wrapper usage by replacing SharpCompressStream.Create(stream, leaveOpen: true) with direct stream usage in BinaryReader constructors across XZ compression components.
- Simplified BinaryReader instantiation by removing SharpCompressStream wrapper
- Updated three XZ component classes to use direct stream access
- Maintained the same leaveOpen behavior using BinaryReader's leaveOpen parameter
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/SharpCompress/Compressors/Xz/XZIndex.cs | Removed SharpCompressStream wrapper in FromStream method |
| src/SharpCompress/Compressors/Xz/XZHeader.cs | Removed SharpCompressStream wrapper in FromStream method |
| src/SharpCompress/Compressors/Xz/XZFooter.cs | Removed SharpCompressStream wrapper in FromStream method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This was referenced Nov 28, 2025
This was referenced Dec 8, 2025
This was referenced Dec 15, 2025
This was referenced Dec 22, 2025
This was referenced Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while doing #958