Reduce custom utilities for arrays/bytes #967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the utility library by removing custom implementations in favor of framework-provided functionality. The changes reduce maintenance burden and leverage well-tested platform APIs, particularly for stream operations and array handling.
Key changes include:
- Replacing custom
TransferTowith framework'sCopyTofor stream operations - Using
Buffer.BlockCopyinstead of custom array copy wrapper - Consolidating namespace structure by removing the
Helpersnamespace - Adding comprehensive unit tests for existing utility methods
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/SharpCompress.Test/UtilityTests.cs | Adds comprehensive test coverage for utility methods including URShift, ReadFully, Skip, date conversions, and other helper functions |
| tests/SharpCompress.Test/TestBase.cs | Removes global using directive for Helpers namespace |
| tests/SharpCompress.Test/Tar/TarReaderTests.cs | Replaces TransferTo with standard CopyTo |
| tests/SharpCompress.Test/Rar/RarReaderTests.cs | Replaces TransferTo with standard CopyTo |
| src/SharpCompress/Writers/Zip/ZipWriter.cs | Replaces TransferTo with standard CopyTo |
| src/SharpCompress/Writers/GZip/GZipWriter.cs | Replaces TransferTo with standard CopyTo |
| src/SharpCompress/Utility.cs | Removes custom array copy, TransferTo overloads, Find, CheckNotNull methods; refactors Skip methods; adds NET60_OR_GREATER conditional compilation for ReadFully |
| src/SharpCompress/Readers/Zip/ZipReader.cs | Updates CheckNotNull to NotNull |
| src/SharpCompress/Readers/Tar/TarReader.cs | Updates CheckNotNull to NotNull |
| src/SharpCompress/Readers/ReaderFactory.cs | Updates CheckNotNullOrEmpty to NotNullOrEmpty and CheckNotNull to NotNull |
| src/SharpCompress/Readers/Rar/RarReader.cs | Updates CheckNotNullOrEmpty to NotNullOrEmpty and CheckNotNull to NotNull |
| src/SharpCompress/Readers/GZip/GZipReader.cs | Updates CheckNotNull to NotNull |
| src/SharpCompress/Readers/Arc/ArcReader.cs | Updates CheckNotNull to NotNull |
| src/SharpCompress/NotNullExtensions.cs | Adds NotNullOrEmpty method and updates Empty methods to use collection expression syntax |
| src/SharpCompress/LazyReadOnlyCollection.cs | Updates namespace from Helpers to SharpCompress |
| src/SharpCompress/Factories/Factory.cs | Updates CheckNotNull to NotNull |
| src/SharpCompress/Compressors/Rar/UnpackV2017/Unpack.unpack50_cpp.cs | Replaces custom Copy with Buffer.BlockCopy |
| src/SharpCompress/Archives/Zip/ZipArchive.cs | Updates CheckNotNullOrEmpty to NotNull and CheckNotNull to NotNull |
| src/SharpCompress/Archives/Tar/TarArchive.cs | Updates CheckNotNullOrEmpty to NotNullOrEmpty and CheckNotNull to NotNull; replaces TransferTo with CopyTo |
| src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs | Updates CheckNotNullOrEmpty to NotNullOrEmpty and CheckNotNull to NotNull |
| src/SharpCompress/Archives/Rar/RarArchive.cs | Updates CheckNotNullOrEmpty to NotNullOrEmpty and CheckNotNull to NotNull |
| src/SharpCompress/Archives/IArchiveEntryExtensions.cs | Replaces TransferTo with standard CopyTo |
| src/SharpCompress/Archives/GZip/GZipArchive.cs | Updates CheckNotNullOrEmpty to NotNullOrEmpty and CheckNotNull to NotNull |
| src/SharpCompress/Archives/ArchiveFactory.cs | Updates CheckNotNullOrEmpty to NotNullOrEmpty and CheckNotNull to NotNull |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This was referenced Nov 28, 2025
This was referenced Dec 8, 2025
This was referenced Dec 8, 2025
This was referenced Dec 22, 2025
This was referenced Dec 29, 2025
This was referenced Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trust the framework