Skip to content

Conversation

@adamhathcock
Copy link
Owner

No description provided.

@adamhathcock adamhathcock requested a review from Copilot October 22, 2025 09:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates NuGet package dependencies across the SharpCompress project, focusing on version bumps for testing and runtime packages. The primary goal is to ensure correct framework-specific dependencies while upgrading to newer package versions.

  • Updated Microsoft.NET.Test.Sdk from 17.13.0 to 18.0.0
  • Bumped System.Buffers from 4.6.0 to 4.6.1 and System.Memory from 4.6.0 to 4.6.3
  • Restructured SharpCompress.csproj to apply dependencies conditionally based on target framework

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tests/SharpCompress.Test/packages.lock.json Updated test SDK and transitive dependencies to newer versions
src/SharpCompress/packages.lock.json Updated package versions and reorganized framework-specific dependency entries
src/SharpCompress/SharpCompress.csproj Moved System.Buffers to framework-conditional ItemGroup and added framework-specific dependencies
Directory.Packages.props Updated centrally managed package versions for System.Buffers, System.Memory, and test SDK

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@adamhathcock adamhathcock merged commit 76afa7d into master Oct 22, 2025
2 checks passed
@adamhathcock adamhathcock deleted the adam/rework-deps branch October 22, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants