-
Notifications
You must be signed in to change notification settings - Fork 499
Fix GZip extraction NotSupportedException for non-seekable streams #987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adamhathcock
merged 6 commits into
master
from
copilot/fix-gzip-extract-not-supported-exception
Oct 27, 2025
Merged
Fix GZip extraction NotSupportedException for non-seekable streams #987
adamhathcock
merged 6 commits into
master
from
copilot/fix-gzip-extract-not-supported-exception
Oct 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
- Modified GZipFilePart to only access stream.Position when stream.CanSeek is true - Modified GZipArchiveEntry.OpenEntryStream to check CanSeek before accessing Position - Added test case GZip_Archive_NonSeekableStream to verify non-seekable stream support - All existing tests pass Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix NotSupportedException in HttpBaseStream Gzip extraction
Fix GZip extraction NotSupportedException for non-seekable streams
Oct 27, 2025
adamhathcock
approved these changes
Oct 27, 2025
This was referenced Nov 28, 2025
This was referenced Dec 8, 2025
This was referenced Dec 15, 2025
This was referenced Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GZip decompression fails when reading from non-seekable streams (e.g.,
HttpClient.GetStreamAsync()) becauseGZipFilePartunconditionally accessesstream.Position, which throwsNotSupportedExceptionon HTTP streams.Changes
GZipFilePart.cs: Check
stream.CanSeekbefore accessingPosition. SetEntryStartPosition = 0for non-seekable streams since they read sequentially from current position.GZipArchiveEntry.cs: Check
CanSeekbefore attempting position reset inOpenEntryStream().Test coverage: Added
GZip_Archive_NonSeekableStreamtest using aNonSeekableStreamwrapper to verify the fix.Usage
Note:
GZipReadersupports non-seekable streams.GZipArchive.Open()continues to require seekable streams by design.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.