-
Notifications
You must be signed in to change notification settings - Fork 499
Add support for empty directory entries in archives #989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for adding empty directories to archives
Add support for empty directory entries in archives
Oct 28, 2025
adamhathcock
approved these changes
Oct 28, 2025
Owner
|
@copilot format this code |
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
Contributor
Author
adamhathcock
approved these changes
Oct 28, 2025
This was referenced Nov 28, 2025
This was referenced Dec 1, 2025
This was referenced Dec 8, 2025
This was referenced Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for empty directory entries in archives
Summary
Successfully implemented support for adding empty directory entries to archives, addressing the feature request in issue #831.
Completed Tasks
WriteDirectorymethods toIWriterinterface for adding empty directory entriesWriteDirectoryinTarWriter(using EntryType.Directory)WriteDirectoryinZipWriter(using trailing '/' with zero size)GZipWriter(throw NotSupportedException as GZip doesn't support directories)AddDirectoryEntrymethods toIWritableArchiveinterfaceImplementation Details
Public API Additions:
IWriter.WriteDirectory(string directoryName, DateTime? modificationTime)- synchronousIWriter.WriteDirectoryAsync(string directoryName, DateTime? modificationTime, CancellationToken)- asynchronousIWritableArchive.AddDirectoryEntry(string key, DateTime? modified)- add directory to archiveFormat-Specific Behavior:
EntryType.Directorywith size 0, directories end with '/'ZipCompressionMethod.NoneNotSupportedException(format limitation)Backward Compatibility:
All existing functionality preserved. Changes are additive only.
Testing
Usage Example
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.