Skip to content

Conversation

@adamhathcock
Copy link
Owner

This pull request improves platform-specific test handling for symbolic links in tar archives, specifically targeting Linux environments. The main changes involve updating conditional compilation symbols and simplifying logic related to symlink extraction in the test suite.

Platform-specific test improvements:

  • Added a LINUX compilation constant in the SharpCompress.Test.csproj file to enable Linux-specific code paths in tests.
  • Changed the conditional compilation in TarReaderTests.cs to use #if LINUX instead of runtime OS checks, ensuring that the symlink extraction test only runs on Linux.

Code simplification for symlink extraction:

  • Removed unnecessary runtime checks (isWindows) and simplified the symbolic link handling logic in the Tar_GZip_With_Symlink_Entries test, making the code cleaner and more maintainable. [1] [2]

@adamhathcock adamhathcock merged commit 8a108b5 into master Oct 28, 2025
2 checks passed
@adamhathcock adamhathcock deleted the adam/macos-fixes branch October 28, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants