Reduce the frequency in which the main loop runs #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to the issue_Drequest refactoring, the main loop would wait for network connections over the wire. Currently, it runs and sleeps for 100 microseconds before starting over. Refactor so it does less checking each iteration and sleep longer before starting the next iteration.
Contributor
Author
|
This does change default behavior a little - now, it only checks if it should update the LOGLEVEL or pbs_tcp_timeout every 10 seconds. Also, it only calls send_any_hellos_needed() every 10 seconds. I don't think there's any reason to do this every time through the main loop, but I could be wrong here. Let me know if you want me to split these changes into a separate commit. |
ghost
assigned
dbeer
pushed a commit
that referenced
this pull request
Feb 4, 2013
Reduce the frequency in which the main loop runs
|
As far as changing those default behaviors, I think that is another plus for your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to the issue_Drequest refactoring, the main loop would wait for
network connections over the wire. Currently, it runs and sleeps for
100 microseconds before starting over. Refactor so it does less
checking each iteration and sleep longer before starting the next
iteration.