Skip to content

Fix overflow caused by wrong sizeof argument #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knielson merged 1 commit into from
Dec 20, 2012
Merged

Fix overflow caused by wrong sizeof argument #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/server/req_jobobit.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,7 +822,13 @@ int handle_exiting_or_abort_substate(
char job_id[PBS_MAXSVRJOBID+1];
char log_buf[LOCAL_LOG_BUF_SIZE+1];

strcpy(job_id, pjob->ji_qs.ji_jobid);
if (pjob == NULL)
{
log_err(PBSE_BAD_PARAMETER, __func__, "NULL input job pointer");
return(PBSE_BAD_PARAMETER);
}
strncpy(job_id, pjob->ji_qs.ji_jobid, sizeof(job_id) - 1);
job_id[sizeof(job_id) - 1] = '\0';

if (LOGLEVEL >= 2)
{
Expand Down
7 changes: 5 additions & 2 deletions src/server/test/req_jobobit/scaffolding.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,8 +244,11 @@ job *svr_find_job(char *jobid, int get_subjob)

if (bad_job == 0)
{
pjob = calloc(1, sizeof(pjob));
strcpy(pjob->ji_qs.ji_jobid, jobid);
pjob = calloc(1, sizeof(*pjob));
if (jobid != NULL)
{
strncpy(pjob->ji_qs.ji_jobid, jobid, sizeof(pjob->ji_qs.ji_jobid)-1);
}
pjob->ji_wattr[JOB_ATR_reported].at_flags = ATR_VFLAG_SET;

if (reported)
Expand Down