ADDED PROGRAM TO FIND A FACTORIAL OF A NUMBER #23
Open
abhinav2712 wants to merge 3 commits intoadarsh-gupta101:mainfrom
Open
ADDED PROGRAM TO FIND A FACTORIAL OF A NUMBER #23abhinav2712 wants to merge 3 commits intoadarsh-gupta101:mainfrom
abhinav2712 wants to merge 3 commits intoadarsh-gupta101:mainfrom
Conversation
Owner
|
Instead of console logging can you use return statement? |
adarsh-gupta101
requested changes
Oct 24, 2022
Owner
adarsh-gupta101
left a comment
There was a problem hiding this comment.
Please use return statement
Author
|
@adarsh-gupta101 Yeah, did the changes, let me know if they are visible... |
Owner
|
sure thing 👍 |
Owner
|
@abhinav2712 can you use a function taking an argument... |
Author
|
@adarsh-gupta101 I just updated the factorial file and made the function like you asked, Let me know if changes are reflected and also, It would be great if you add hacktoberfest label on this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HI!
I added a program in JS file to find a factorial of a number.
Happy Hacktoberfest !!