Update for Mists #57
Merged
Update for Mists #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-AIOHTTP-10742466
…c9c7c435 [Snyk] Security upgrade aiohttp from 3.10.11 to 3.12.14
There was a problem hiding this comment.
Pull Request Overview
This PR updates the bot for the "Mists of Pandaria" expansion by replacing the BAD_ENCHANTS system with a GOOD_ENCHANTS allowlist and adding new raid zone support.
- Converts enchant validation from blacklist to allowlist approach
- Adds new enchant IDs for Mists of Pandaria content
- Adds MSV and HoF/ToES raid zone configurations
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| slao_bot/utils/enchants.py | Replaces BAD_ENCHANTS blacklist with GOOD_ENCHANTS allowlist and updates enchant IDs for MoP |
| slao_bot/utils/constants.py | Adds zone banners and names for MSV and HoF/ToES raids |
| slao_bot/cogs/gear.py | Updates enchant validation logic to use the new allowlist approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.