Skip to content

AdformBidAdapter. Outstream renderer condition #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bratrahim wants to merge 3 commits into from
Closed

AdformBidAdapter. Outstream renderer condition #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2135d50
Must not apply a renderer if media type is not 'video'
Dec 2, 2019
0bb00eb
The change fixes 2 incorrect behaviours.
Dec 2, 2019
b17530f
ensure renderer is not applied to banners
Dec 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/adformBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ export const spec = {
response = responses[i];
type = response.response === 'banner' ? BANNER : VIDEO;
bid = bids[i];
if (VALID_RESPONSES[response.response] && (verifySize(response, bid.sizes) || type === VIDEO)) {
if (VALID_RESPONSES[response.response] && (verifySize(response, utils.getAdUnitSizes(bid)) || type === VIDEO)) {
bidObject = {
requestId: bid.bidId,
cpm: response.win_bid,
Expand All @@ -117,7 +117,7 @@ export const spec = {
mediaType: type
};

if (!bid.renderer && utils.deepAccess(bid, 'mediaTypes.video.context') === 'outstream') {
if (!bid.renderer && type === VIDEO && utils.deepAccess(bid, 'mediaTypes.video.context') === 'outstream') {
bidObject.renderer = Renderer.install({id: bid.bidId, url: OUTSTREAM_RENDERER_URL});
bidObject.renderer.setRender(renderer);
}
Expand Down
11 changes: 6 additions & 5 deletions test/spec/modules/adformBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,11 +258,12 @@ describe('Adform adapter', function () {
};
});

it('should set a renderer for an outstream context', function () {
serverResponse.body = [serverResponse.body[3]];
bidRequest.bids = [bidRequest.bids[6]];
it('should set a renderer only for an outstream context', function () {
serverResponse.body = [serverResponse.body[3], serverResponse.body[2]];
bidRequest.bids = [bidRequest.bids[6], bidRequest.bids[6]];
let result = spec.interpretResponse(serverResponse, bidRequest);
assert.ok(result[0].renderer);
assert.equal(result[1].renderer, undefined);
});

describe('verifySizes', function () {
Expand Down Expand Up @@ -314,9 +315,9 @@ describe('Adform adapter', function () {
beforeEach(function () {
config.setConfig({ currency: {} });

let sizes = [[250, 300], [300, 250], [300, 600]];
let sizes = [[250, 300], [300, 250], [300, 600], [600, 300]];
let placementCode = ['div-01', 'div-02', 'div-03', 'div-04', 'div-05'];
let mediaTypes = [{video: {context: 'outstream'}}];
let mediaTypes = [{video: {context: 'outstream'}, banner: {sizes: sizes[3]}}];
let params = [{ mid: 1, url: 'some// there' }, {adxDomain: null, mid: 2, someVar: 'someValue', pt: 'gross'}, { adxDomain: null, mid: 3, pdom: 'home' }, {mid: 5, pt: 'net'}, {mid: 6, pt: 'gross'}];
bids = [
{
Expand Down