Add error handling and configurable retries to curl calls#1
Open
heatherbooker wants to merge 3 commits intodevelopfrom
Open
Add error handling and configurable retries to curl calls#1heatherbooker wants to merge 3 commits intodevelopfrom
heatherbooker wants to merge 3 commits intodevelopfrom
Conversation
to curl calls in curlgh
heatherbooker
force-pushed
the
feature/retry-and-better-errors
branch
from
4746c09 to
2aaecb2
Compare
aleveille
reviewed
May 27, 2020
aleveille
left a comment
aleveille
left a comment
There was a problem hiding this comment.
Please remove me from the list of reviewers :)
Have a nice day!
Author
|
Hm I'm not sure why, but I can't remove you. Sorry! >< |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I mashed together @aleveille and @avanier 's commits to improve the rate-limiting situation on this resource (all credit to them!).
They:
I removed the retry from the
outoperation, since now it's covered by thecommonfile. It was originally added in dpb587/github-status-resource/pull/4. I'm not sure if I should remove all the code (and the test) that was added in that PR?