add label.iconSVG key #976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityatelange
requested changes
Jul 16, 2022
Owner
adityatelange
left a comment
adityatelange
left a comment
There was a problem hiding this comment.
I didn't mean for it to come across as a complaint.
I was just looking for a confirmation on the matter to proceed with the PR.
I had already said we can go ahead in discord. Anyways about the svg height, we don't need to implement that.
It is redundant to add iconHeight to replace height in svg. User can add height directly in svg.
Originally posted by @adityatelange in #974 (comment)
adityatelange
requested changes
Jul 17, 2022
Owner
adityatelange
left a comment
adityatelange
left a comment
There was a problem hiding this comment.
Image isn't aligned properly
can you add svg to existing css rules to fit this in?
|
Kudos, SonarCloud Quality Gate passed!
|
adityatelange
approved these changes
Jul 23, 2022
romainx
pushed a commit
to romainx/hugo-PaperMod
that referenced
this pull request
Jul 26, 2022
Usage => Params.label.iconSVG: "<your SVG as a string>"
minyeamer
pushed a commit
to minyeamer/hugo-PaperMod
that referenced
this pull request
Sep 16, 2022
Usage => Params.label.iconSVG: "<your SVG as a string>"
dunklecat
pushed a commit
to dunklecat/hugo-PaperModX
that referenced
this pull request
Oct 9, 2022
Usage => Params.label.iconSVG: "<your SVG as a string>"
kylethedeveloper
pushed a commit
to kylethedeveloper/hugo-PaperMod
that referenced
this pull request
Feb 21, 2023
Usage => Params.label.iconSVG: "<your SVG as a string>"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
This PR adds
label.iconSVGkey under site params. It can be used to embed the SVG directly for easier styling, e.g. for handling the change between dark and light mode.Was the change discussed in an issue or in the Discussions before?
Closes #974.
PR Checklist