chore(folders): mescla quote/→quotes/ e simulation/→simulator/ (F1-1.x) by adm01-debug · Pull Request #113 · adm01-debug/Promo_Gifts

adm01-debug · 2026-05-09T16:46:42Z

Plano

Mescla pastas duplicadas que confundiam quem editava o código.

Mudanças

De	Para	Motivo
`src/components/quote/` (3 arquivos)	`src/components/quotes/` (já 47)	Mesmo conceito, plural só
`src/components/simulation/` (1 arquivo)	`src/components/simulator/` (já 23)	Sufixo inconsistente (action vs noun)

Arquivos movidos:

MarginInsightBadge.tsx → quotes/
NegotiationMarkupCard.tsx → quotes/
QuickQuoteFAB.tsx → quotes/
SimulationPriceSourceBadge.tsx → simulator/

Imports atualizados (2):

src/components/quotes/QuoteBuilderSummaryColumn.tsx (NegotiationMarkupCard)
src/components/layout/GlobalOverlay.tsx (lazyWithRetry dinâmico do QuickQuoteFAB)

Baseline ESLint regenerado pra refletir os novos paths (mesmo total de erros, só keys mudaram).

Risk

🟢 Baixo. Apenas reorganização estrutural. git mv preserva history (ver R no diff).

Test plan

Summary by CodeRabbit

Release Notes

Chores
- Reorganização interna de estrutura de módulos para melhor manutenibilidade.
- Atualização de configurações de linting e metadados de compilação.

Pastas duplicadas (mesmo conceito, diferença só de plural/sufixo) confundiam quem editava o código. Auditoria do relatório original já tinha apontado. Mudanças: - src/components/quote/ (3 arquivos) → src/components/quotes/ (já tinha 47 arquivos) - src/components/simulation/ (1 arquivo) → src/components/simulator/ (já tinha 23 arquivos) - 2 imports atualizados: * src/components/quotes/QuoteBuilderSummaryColumn.tsx * src/components/layout/GlobalOverlay.tsx (lazyWithRetry dinâmico) Risk: 🟢 baixo. Mudanças são apenas estruturais (move + path). Sem mudanças de lógica. Test plan: - [x] git mv preserva history (R em git status) - [x] 0 imports quebrados em src/ - [x] eslint baseline passa (1547=1547) - [ ] vite build verde - [ ] CI verde

vercel · 2026-05-09T16:46:47Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
promo-gifts	Ready	Preview, Comment	May 9, 2026 4:47pm

coderabbitai · 2026-05-09T16:46:59Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1a40f355-684d-49db-9777-7f7b7f52cc3b

📥 Commits

Reviewing files that changed from the base of the PR and between 9d9026b and 68d414e.

📒 Files selected for processing (7)

.eslint-baseline.json
src/components/layout/GlobalOverlay.tsx
src/components/quotes/MarginInsightBadge.tsx
src/components/quotes/NegotiationMarkupCard.tsx
src/components/quotes/QuickQuoteFAB.tsx
src/components/quotes/QuoteBuilderSummaryColumn.tsx
src/components/simulator/SimulationPriceSourceBadge.tsx

Walkthrough

PR reorganiza componentes movendo importações do diretório singular @/components/quote/ para o plural @/components/quotes/. Dois componentes consumidores (GlobalOverlay e QuoteBuilderSummaryColumn) têm seus caminhos de importação atualizados, seguido pela atualização do timestamp e reordenação de entradas no arquivo de baseline do lint.

Changes

Reorganização quote/ → quotes/

Layer / File(s)	Summary
Atualização de Caminhos de Importação `src/components/layout/GlobalOverlay.tsx`, `src/components/quotes/QuoteBuilderSummaryColumn.tsx`	Importações de `QuickQuoteFAB` e `NegotiationMarkupCard` atualizadas de `@/components/quote/` para `@/components/quotes/`.
Metadados do Lint Baseline `.eslint-baseline.json`	Timestamp regenerado e entradas de `counts` para componentes de quotes reordenadas sem alterar contagens de regras.

Estimated code review effort

🎯 2 (Simples) | ⏱️ ~8 minutos

Possibly related PRs

adm01-debug/Promo_Gifts#107: Ambos os PRs modificam .eslint-baseline.json, atualizando metadados e contagens de baseline.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	O título é específico e claro: descreve a reorganização de duas pastas duplicadas (quote→quotes e simulation→simulator) com a branch/contexto (F1-1.x).
Description check	✅ Passed	A descrição está bem estruturada com plano, mudanças detalhadas em tabela, arquivos movidos, imports atualizados, baseline ESLint e risk assessment. Faltam apenas seções UI/screenshots e teste de CI/CodeRabbit (já marcadas como pendentes).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/merge-duplicate-folders

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

chatgpt-codex-connector

💡 Codex Review

Promo_Gifts/src/components/simulator/SimulationPriceSourceBadge.tsx

Line 2 in 68d414e

* SimulationPriceSourceBadge

Update the test import after moving the badge

After moving this component from src/components/simulation to src/components/simulator, the existing test still imports @/components/simulation/SimulationPriceSourceBadge (tests/components/SimulationPriceSourceBadge.test.tsx:6). In environments that run the component tests, Vitest/Vite will fail module resolution because the old file was deleted, so the test suite cannot start for this file.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot

Pull request overview

Reorganiza a árvore de componentes para eliminar pastas duplicadas e padronizar nomes (quote/ → quotes/, simulation/ → simulator/), reduzindo confusão na manutenção e mantendo imports consistentes no app.

Changes:

Move componentes de quote/ para quotes/ e de simulation/ para simulator/.
Atualiza imports de consumo em QuoteBuilderSummaryColumn e no lazy import do GlobalOverlay.
Regenera .eslint-baseline.json para refletir os novos paths.

Reviewed changes

Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/components/simulator/SimulationPriceSourceBadge.tsx	Componente agora localizado em `simulator/` (move/organização).
src/components/quotes/QuoteBuilderSummaryColumn.tsx	Ajuste de import para `NegotiationMarkupCard` no novo path.
src/components/quotes/QuickQuoteFAB.tsx	Componente agora localizado em `quotes/` (move/organização).
src/components/quotes/NegotiationMarkupCard.tsx	Componente agora localizado em `quotes/` (move/organização).
src/components/quotes/MarginInsightBadge.tsx	Componente agora localizado em `quotes/` (move/organização).
src/components/layout/GlobalOverlay.tsx	Atualiza lazy import do `QuickQuoteFAB` para `quotes/`.
.eslint-baseline.json	Atualiza chaves do baseline para refletir novos caminhos.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

## Problema 1: CI quebrado em main desde PR #113 Após auditoria pós-#117 descobri que **"Lint, Typecheck & Test"** tem falhado em **5 runs consecutivos em main** (desde PR #113). Causa raiz: 2 entries do .tsc-baseline.json desalinhadas com a realidade pós-#113 e #116: 1. **PR #113** moveu `src/components/quote/QuickQuoteFAB.tsx` → `quotes/`. Baseline ficou no path antigo. Gate vê isso como "+2 TS2322 novos no path `quotes/`". 2. **PR #116** consertou ProductDetail.tsx (-91 erros líquidos), mas introduziu 6 novos TS2322. Baseline fica preso em TS2322=3, vê regressão de +6. Patch cirúrgico (sem rodar tsc): - `del .counts["src/components/quote/QuickQuoteFAB.tsx"]` (path antigo) - `.counts["src/components/quotes/QuickQuoteFAB.tsx"] = {TS2322: 2}` (path novo) - `.counts["src/pages/ProductDetail.tsx"] = {TS2322: 9}` (atualiza pra realidade pós-#116) - Recalcula totalErrors via `jq` **Resultado: baseline 1214 → 1132 erros** (alinhado com o tsc real que reporta 1130, +2 de drift positivo aceito). ## Problema 2: gen-edges-readme.mjs não roda standalone PR #117 prometeu reproduzibilidade via `node scripts/gen-edges-readme.mjs > supabase/functions/README.md`, mas o script tinha 2 `readFileSync('/tmp/edge-*.txt')` deixados da geração inicial — quebrava se /tmp não tivesse os arquivos. Reescrito standalone: - `readdirSync(supabase/functions)` em vez de `/tmp/edge-dirs.txt` - `execSync(grep -rE ...)` em vez de `/tmp/edge-callers.txt` - Validado: `node scripts/gen-edges-readme.mjs` produz 196 linhas idênticas ao README atual ## Risk 🟢 Zero. Baseline mais rigoroso (gate fica menor, não maior). Script mais portável. ## Test plan - [x] `jq '.totalErrors' .tsc-baseline.json` = 1132 (era 1214) - [x] `jq '.counts | has("src/components/quote/QuickQuoteFAB.tsx")'` = false - [x] `node scripts/gen-edges-readme.mjs` roda standalone (sem /tmp) - [ ] CI verde (este é o teste real) - [ ] CodeRabbit OK

Copilot AI review requested due to automatic review settings May 9, 2026 16:46

Copilot started reviewing on behalf of adm01-debug May 9, 2026 16:47 View session

vercel Bot deployed to Preview May 9, 2026 16:47 View deployment

chatgpt-codex-connector Bot reviewed May 9, 2026

View reviewed changes

Copilot AI reviewed May 9, 2026

View reviewed changes

adm01-debug merged commit 87451fe into main May 9, 2026
18 of 19 checks passed

adm01-debug deleted the chore/merge-duplicate-folders branch May 9, 2026 16:54

adm01-debug mentioned this pull request May 9, 2026

fix(ci): destrava CI em main + gen-edges-readme standalone (F1-1.x encerramento) #118

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(folders): mescla quote/→quotes/ e simulation/→simulator/ (F1-1.x)#113

chore(folders): mescla quote/→quotes/ e simulation/→simulator/ (F1-1.x)#113
adm01-debug merged 1 commit into
mainfrom
chore/merge-duplicate-folders

adm01-debug commented May 9, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented May 9, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 9, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

adm01-debug commented May 9, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Plano

Mudanças

Risk

Test plan

Summary by CodeRabbit

Release Notes

Uh oh!

vercel Bot commented May 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented May 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

adm01-debug commented May 9, 2026 •

edited by coderabbitai Bot

Loading

vercel Bot commented May 9, 2026 •

edited

Loading

coderabbitai Bot commented May 9, 2026 •

edited

Loading