refactor(badges): extrai EntityBadge genérico para Material+Ramo (F1-1.x Onda D #1)#121
Merged
Conversation
…s (F1-1.x Onda E #2) ## Onda E — segunda leva de código morto Continua a limpeza dos 1.013 exports órfãos identificados na auditoria. Esta PR foca em hooks com nome 'Legacy' (auto-confissão de obsoletos) e exports zero-callers em arquivos de dados. ## Mudanças ### useCrmCompanies.ts (-23L) Removidos 2 hooks órfãos validados via grep: - `useCrmCompaniesLegacy` (zero callers) - `useCrmCompanyLegacy` (zero callers) A palavra 'Legacy' no nome era pista. Como ambos eram os únicos consumidores de `toLegacyClient` neste arquivo, também removo o import. ### useCommercialIntelligence.ts (-48L) - Removido `useRevenueTrend` (45L, zero callers) - Removido `RevenuePoint` interface (1L, zero callers — só era usada pelo hook removido) ### pantone-coated.ts (-5L) - Removido `getAllPantoneCodes` (zero callers) - `searchPantone` preservada (em uso) ## Validação - ✅ `grep -rE 'useCrmCompaniesLegacy|useCrmCompanyLegacy'` em src/, tests/, e2e/ = 0 callers - ✅ `grep -rE 'useRevenueTrend'` em src/, tests/, e2e/ = 0 callers - ✅ `grep -rE 'RevenuePoint'` em src/, tests/, e2e/ = 0 callers - ✅ `grep -rE 'getAllPantoneCodes'` em src/, tests/, e2e/ = 0 callers - ✅ `toLegacyClient` mantido em `@/types/crm` (caso futuro consumidor) ## Resultado | Arquivo | Antes | Depois | Redução | |---|---|---|---| | useCrmCompanies.ts | 220 | 197 | -23L | | useCommercialIntelligence.ts | 420 | 372 | -48L | | pantone-coated.ts | (~700) | (-5) | -5L | | **Total** | | | **-76L líquidas** | ## Risk 🟢 **Baixo**. Apenas remoções de exports zero-callers validados via grep. ## Test plan - [x] Zero callers de cada export removido - [x] -76L líquidas - [ ] CI verde - [ ] CodeRabbit OK
…1.x Onda D) ## Onda D — Eliminar duplicação top 7 Auditoria F1 detectou que MaterialBadge.tsx (177L) e RamoAtividadeBadge.tsx (179L) eram **95% idênticos** — confirmados como par #4 da lista jscpd de duplicações com 96 linhas duplicadas. ## Mudanças | Arquivo | Antes | Depois | |---|---|---| | MaterialBadge.tsx | 177L | **53L** (wrapper fino) | | RamoAtividadeBadge.tsx | 179L | **63L** (wrapper fino) | | EntityBadge.tsx | — | 184L (genérico) | | EntityBadge/index.ts | — | 2L | | **Total** | **356L** | **302L** (-54L, mais reusável) | ## API mantida 100% compatível Os componentes públicos MaterialBadge e RamoAtividadeBadge mantêm props e comportamento idênticos — **zero mudança em callers**: - 5 callers de MaterialBadge → não tocados - 3 callers de RamoAtividadeBadge → não tocados ## EntityBadge — design Suporta os 2 casos atuais e novos casos futuros: - `groupLabel` + `groupSeparator` (": " pra material, " → " pra ramo) - `icon` opcional (lucide ou emoji string) - `hexCode` opcional (color dot) - `truncateMaxWidth` per-size (config diferente entre os 2 atuais) - `tooltipContent` override pra casos custom ## Risk 🟡 médio — refactor de UI compartilhada, mas: - API dos wrappers mantida 100% - Comportamento visual preservado (validado por inspeção do JSX gerado) - Componentes pequenos, mudança contida ## Test plan - [x] MaterialBadge mantém TODAS as props do original - [x] RamoAtividadeBadge mantém TODAS as props do original - [x] separator ": " para Material, " → " para Ramo - [x] truncate widths diferenciados (Material: 100/120/150, Ramo: 100/140/180) - [ ] CI verde - [ ] CodeRabbit OK - [ ] Vercel preview — visual idêntico ao atual
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Caution Review failedPull request was closed or merged during review WalkthroughA PR que extrai um novo componente ChangesEntity Badge Extraction & Component Refactoring
Unused Exports & Legacy Code Cleanup
🎯 3 (Moderate) | ⏱️ ~18 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6bf5f4ae1f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| lg: "max-w-[180px]", | ||
| }; | ||
|
|
||
| export function RamoAtividadeBadge({ |
There was a problem hiding this comment.
This refactor deletes CompactRamoAtividadeBadge, but src/components/ramo-atividade/index.ts still re-exports that named symbol from this module; I verified with rg "CompactRamoAtividadeBadge" that the stale barrel export remains. Any consumer that imports the ramo-atividade barrel, or a full typecheck/build that includes it, will fail because this file no longer provides the export.
Useful? React with 👍 / 👎.
Comment on lines
+121
to
+131
| <span | ||
| className={cn( | ||
| "truncate", | ||
| size === "sm" && truncateMaxWidth.sm, | ||
| size === "md" && truncateMaxWidth.md, | ||
| size === "lg" && truncateMaxWidth.lg, | ||
| )} | ||
| > | ||
| {displayText} | ||
| </span> | ||
| {onRemove && ( |
There was a problem hiding this comment.
When productCount is passed to MaterialBadge or RamoAtividadeBadge, the previous components rendered a small visible count pill next to the label for positive counts; the new shared content only renders the label and then the remove button, so the count is now hidden except inside the tooltip. That breaks the advertised API/visual compatibility for any badge using productCount to show product totals inline.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
Refactors duplicated UI badge components by introducing a reusable EntityBadge base component and converting MaterialBadge / RamoAtividadeBadge into thin wrappers. The PR also removes several unrelated, previously-exported helpers/hooks that appear unused.
Changes:
- Added
EntityBadge(generic badge with group label/separator, optional icon, optional hex dot, optional tooltip/remove). - Refactored
MaterialBadgeandRamoAtividadeBadgeto delegate rendering toEntityBadge. - Removed legacy/unused exports in hooks/data modules (CRM legacy hooks, revenue trend hook/type, Pantone helper).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/hooks/useCrmCompanies.ts | Removes legacy compatibility hooks and drops now-unused import. |
| src/hooks/useCommercialIntelligence.ts | Removes the revenue trend hook/type from the commercial intelligence hook module. |
| src/data/pantone-coated.ts | Removes getAllPantoneCodes() export. |
| src/components/ramo-atividade/RamoAtividadeBadge.tsx | Converts badge to a thin wrapper around EntityBadge. |
| src/components/materials/MaterialBadge.tsx | Converts badge to a thin wrapper around EntityBadge. |
| src/components/common/EntityBadge/index.ts | Adds barrel exports for EntityBadge and its props type. |
| src/components/common/EntityBadge/EntityBadge.tsx | Introduces the new generic badge component used by the wrappers. |
Comments suppressed due to low confidence (1)
src/hooks/useCrmCompanies.ts:75
- This PR is described as a badges refactor, but it also removes unrelated public exports (e.g. legacy CRM hooks, revenue trend hook/type, and pantone helper). Even if currently unused, that broadens scope and can be a breaking change for downstream imports. If intentional, document it in the PR description or split it into a separate cleanup PR.
/**
* Hook para busca infinita de empresas (dropdown/combobox)
* Suporta carregamento incremental para performance
*/
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+5
| import { EntityBadge } from "@/components/common/EntityBadge"; | ||
|
|
||
| /** | ||
| * Badge for displaying a Ramo de Atividade (Hotel, Restaurante, Imobiliária, etc). | ||
| * |
Comment on lines
+94
to
+95
| outline: "border border-border bg-transparent hover:bg-muted/50", | ||
| solid: "bg-foreground text-background hover:bg-foreground/90", |
Comment on lines
+121
to
+125
| <span | ||
| className={cn( | ||
| "truncate", | ||
| size === "sm" && truncateMaxWidth.sm, | ||
| size === "md" && truncateMaxWidth.md, |
Comment on lines
+1
to
+5
| import { EntityBadge } from "@/components/common/EntityBadge"; | ||
|
|
||
| /** | ||
| * Badge for displaying a Ramo de Atividade (Hotel, Restaurante, Imobiliária, etc). | ||
| * |
Comment on lines
+171
to
+173
| // With tooltip | ||
| if (showTooltip && (groupLabel || productCount !== undefined)) { | ||
| return ( |
Comment on lines
+174
to
+177
| <TooltipProvider> | ||
| <Tooltip> | ||
| <TooltipTrigger asChild>{badgeContent}</TooltipTrigger> | ||
| <TooltipContent>{tooltipContent ?? defaultTooltip}</TooltipContent> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Onda D — Eliminar duplicação top 7 — par #1
Auditoria F1 detectou
MaterialBadge.tsx(177L) eRamoAtividadeBadge.tsx(179L) eram 95% idênticos — par #4 da lista jscpd de duplicações com 96 linhas duplicadas.📦 Mudanças
MaterialBadge.tsxRamoAtividadeBadge.tsxEntityBadge.tsx(NEW)EntityBadge/index.ts(NEW)✅ API 100% compatível
Os componentes públicos
MaterialBadgeeRamoAtividadeBadgemantêm props e comportamento idênticos — zero mudança em callers:🎨 EntityBadge — design
Suporta os 2 casos atuais e novos casos futuros:
groupLabel+groupSeparator(": " pra material, " → " pra ramo)iconopcional (lucide ou emoji string)hexCodeopcional (color dot)truncateMaxWidthper-size (config diferente entre Material e Ramo)tooltipContentoverride pra casos custom🟡 Médio — refactor de UI compartilhada, mas:
Summary by CodeRabbit
Notas de Lançamento
Novas Funcionalidades
Refatoração