chore(edges): remove quote-public-view stub (descontinuada)#131
Conversation
A função quote-public-view era stub 501 nunca implementado. Decisão do PO: remover do projeto em vez de implementar. - supabase/functions/quote-public-view/index.ts: deletado (era stub 501) - Validado antes de remover: zero registros em ai_function_routing, zero registros em ai_usage_logs, sem referências de import no frontend. A edge function correspondente em prod (Supabase) foi deletada via Management API/Dashboard.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughO PR remove integralmente o arquivo de função edge AlteraçõesRemoção do Endpoint quote-public-view
Considerações de review🔍 Verificar:
🎯 2 (Simple) | ⏱️ ~5-10 minutos 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated/unimplemented Supabase Edge Function quote-public-view (previously a 501 stub) based on a PO decision to drop the feature instead of implementing it.
Changes:
- Deleted
supabase/functions/quote-public-view/index.ts(stub 501 entrypoint). - Removes the repository’s on-disk entrypoint for the
quote-public-viewedge function.
Comments suppressed due to low confidence (1)
supabase/functions/quote-public-view/index.ts:1
- Ao remover a edge
quote-public-view, ainda ficaram referências no repo que vão quebrar gates de CI e/ou manter drift: (1)_shared/edge-authz-manifest.tsainda declaraquote-public-view, e oscripts/check-edge-authorization.mjsfalha quando há entry no manifest sem diretório correspondente; (2)scripts/check-edge-structured-logging.mjstemquote-public-viewnaLEGACY_ALLOWLISTe falha comorphanAllowlistquando a edge não existe; (3)supabase/config.tomlainda tem[functions.quote-public-view]; (4)_shared/cors-snapshot.jsonainda lista a função. Recomendo remover/atualizar esses arquivos no mesmo PR para manter o repo consistente e passar CI.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 464765f00b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,51 +0,0 @@ | |||
| // ============================================================ | |||
There was a problem hiding this comment.
When this deletion removes quote-public-view/index.ts, the repo still declares quote-public-view in _shared/edge-authz-manifest.ts and the legacy logging allowlist, so the CI gates run from .github/workflows/ci.yml now report this edge as declared/allowlisted but missing from supabase/functions/. I confirmed node scripts/check-edge-authorization.mjs emits Manifest declara "quote-public-view" mas a função não existe, and node scripts/check-edge-structured-logging.mjs also flags the stale allowlist entry; please remove the associated manifest/config/snapshot entries in the same change as the function deletion.
Useful? React with 👍 / 👎.
Estende delete-orphan-edges.yml com um input opcional `extraEdges` (CSV) que permite passar uma lista de edges adicionais a serem deletadas além das 6 órfãs originais. Útil para limpezas pontuais que vêm depois (ex.: stubs removidos via PR mas com a edge ainda viva em prod). Uso: Run workflow → extraEdges = "edge1,edge2" + dryRun=false + confirm=DELETE Caso de uso imediato: deletar quote-public-view (PR #131 mergeado, edge ainda em prod) e generate-mockup-nanobanana (PR #132 mergeado, edge ainda em prod).
…ais (#134) Estende delete-orphan-edges.yml com um input opcional `extraEdges` (CSV) que permite passar uma lista de edges adicionais a serem deletadas além das 6 órfãs originais. Útil para limpezas pontuais que vêm depois (ex.: stubs removidos via PR mas com a edge ainda viva em prod). Uso: Run workflow → extraEdges = "edge1,edge2" + dryRun=false + confirm=DELETE Caso de uso imediato: deletar quote-public-view (PR #131 mergeado, edge ainda em prod) e generate-mockup-nanobanana (PR #132 mergeado, edge ainda em prod).
Stub 501 nunca implementado. Decisão do PO: remover do projeto em vez de implementar.
Validação antes da remoção
ai_function_routingapontando para esta functionai_usage_logs(nunca foi chamada)Mudanças
supabase/functions/quote-public-view/index.tsdeletado (era stub 501)Próximo passo (manual)
Após mergear, deletar a edge function de prod via Supabase Dashboard ou
Management API. ID da função no projeto
doufsxqlfjyuvxuezpln:dd4c2c8f-4dbf-498c-94e5-5b5fea861c8a(deploy v4).Summary by CodeRabbit
Release Notes