fix(ci): zerar thresholds CLI em report-only coverage jobs (close 25925328625) by adm01-debug · Pull Request #228 · adm01-debug/Promo_Gifts

adm01-debug · 2026-05-15T16:18:06Z

Problema

Job Edge Integration & Fuzzing vinha falhando no step Generate Coverage Report (JSON/HTML) (run 25925328625, job 76213269690) com:

ERROR: Coverage for lines (26.62%) does not meet global threshold (60%)
ERROR: Coverage for functions (32.47%) does not meet global threshold (60%)
ERROR: Coverage for statements (26.62%) does not meet global threshold (60%)
Process completed with exit code 1.

Os testes passaram (341 test files / 6395 testes). O que derruba o job é o thresholds: { lines: 60, functions: 60, branches: 50, statements: 60 } do vitest.config.ts aplicado pelo provider v8 toda vez que --coverage está ativo — independente do propósito do step.

Mesma raiz no job Test Coverage (step Run tests with coverage), também flagged como falhando há 3+ commits (60d942f, 52710b8, a67deaf).

Por que esses 2 jobs não deveriam aplicar threshold global

Ambos são report-only: existem para subir artifact JSON/HTML de cobertura para inspeção pós-merge. Os gates de cobertura reais são per-file e ficam em jobs dedicados:

cloud-status-tests
price-freshness-tests
hooks-tests
critical-e2e (Enforce Critical Coverage → npm run check:critical-coverage)

Fix

Override CLI dos 4 thresholds (=0) só nesses 2 steps report-only. Padrão idiomático já em uso no job price-freshness-tests deste mesmo ci.yml — este PR só estende para os outros 2 jobs report-only.

Validação local

Probe com tests/lib/cn.test.ts no VPS:

sem overrides → 4× ERROR: Coverage for ... does not meet global threshold ... no output (exit 1)
com overrides → saída limpa, sem erros de threshold

Escopo

1 arquivo (.github/workflows/ci.yml), +18 −2 linhas
0 testes alterados, 0 código de produção alterado
vitest.config.ts permanece com thresholds: 60 para dev local

Não corrigido (pendências pré-existentes confirmadas, NÃO regressão deste PR)

Supabase Preview failing (Remote migration versions not found...) — em andamento via PR fix(migrations): baseline_sync no-op + placeholder para versão 20250103 #222 baseline_sync
GitHub PAT exposto no git remote -v do VPS — deve ser revogado por segurança

Summary by cubic

Zeroed global coverage thresholds in report-only CI steps to stop false failures while preserving per-file and critical coverage gates. Coverage reports still upload as artifacts.

Bug Fixes
- Updated .github/workflows/ci.yml to pass --coverage.thresholds.{lines,functions,branches,statements}=0 to npx vitest run --coverage in Test Coverage and Edge Integration & Fuzzing report steps.
- Kept vitest.config.ts thresholds unchanged; real gates run per-file in cloud-status-tests, price-freshness-tests, hooks-tests, and critical-e2e.
- Outcome: report-only steps no longer fail the build; JSON/HTML coverage artifacts are still generated.

^{Written for commit 73bb7b5. Summary will update on new commits. Review in cubic}

Summary by CodeRabbit

Chores
- Melhorias na pipeline de CI/CD: o processamento de relatório de cobertura agora opera de forma independente, focando exclusivamente na geração de relatórios sem validação de métricas específicas
- Testes de integração agora geram relatórios de cobertura em múltiplos formatos (JSON e HTML), além do relatório textual padrão

…rage + Edge Integration) Os 2 steps `Run tests with coverage` (job Test Coverage) e `Generate Coverage Report (JSON/HTML)` (job Edge Integration & Fuzzing) rodavam `npx vitest run --coverage` sem override de thresholds. O `vitest.config.ts` declara `thresholds: { lines: 60, functions: 60, branches: 50, statements: 60 }` e o v8 provider sai com exit 1 sempre que a cobertura real fica abaixo (atualmente lines=26.62%, functions=32.47%, statements=26.62%) — derrubando o CI mesmo com 6395 testes passando. Esses 2 jobs são report-only: existem para subir artifact JSON/HTML de cobertura para inspeção pós-merge. Os gates de cobertura **reais** são per-file e ficam em jobs dedicados (Cloud Status, Price Freshness, Hook tests, Critical Flows E2E `check:critical-coverage`). O job `price-freshness-tests` neste mesmo workflow já usa exatamente esse padrão idiomático (`--coverage.thresholds.{lines,functions, branches,statements}=0`); este PR estende para os outros 2 jobs report-only, fechando a falha que vinha quebrando o CI há 3+ commits (60d942f, 52710b8, a67deaf). Mudanças mínimas — `.github/workflows/ci.yml` apenas, +18 −2 linhas, 0 testes alterados, 0 código de produção alterado. O `vitest.config.ts` permanece com `thresholds: 60` para dev local e para qualquer job que queira ativar o gate global no futuro. Validação local da sintaxe (probe com `tests/lib/cn.test.ts`): - sem overrides → 4 ERROR de threshold no output (exit 1) - com overrides → output limpo, sem erros de threshold

vercel · 2026-05-15T16:18:11Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
promo-gifts	Ready	Preview, Comment	May 15, 2026 4:18pm

supabase · 2026-05-15T16:18:13Z

This pull request has been ignored for the connected project doufsxqlfjyuvxuezpln because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

coderabbitai · 2026-05-15T16:18:21Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8cf77766-5059-4a95-8d04-78202bfddd4e

📥 Commits

Reviewing files that changed from the base of the PR and between a67deaf and 73bb7b5.

📒 Files selected for processing (1)

.github/workflows/ci.yml

Walkthrough

O workflow de CI foi ajustado para padronizar os jobs de cobertura em modo "report-only". O job coverage agora zera explicitamente thresholds globais via flags CLI. O job integration-tests recebeu reporters adicionais (json, html) e também zera os mesmos thresholds, mantendo a cobertura como relatório descritivo sem bloquear a execução.

Changes

Configuração de Coverage Report no Workflow CI

Layer / File(s)	Summary
Coverage threshold e reporter configuration `.github/workflows/ci.yml`	Os jobs `coverage` e `integration-tests` executam Vitest com flags `--coverage.thresholds.{lines,functions,branches,statements}=0` para modo report-only. O job `integration-tests` adiciona reportes json e html aos reporters existentes, consolidando a geração de artefatos de cobertura sem impacto na validação.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutos

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	O título descreve com precisão a mudança principal: zerando thresholds CLI em jobs report-only de cobertura, exatamente o que as alterações fazem.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/ci-coverage-report-thresholds

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

Fixes CI failures in two report-only coverage jobs (Test Coverage and Edge Integration & Fuzzing) by zeroing the global coverage thresholds at the CLI level, since the real coverage gates are enforced per-file in other dedicated jobs.

Changes:

Add --coverage.thresholds.{lines,functions,branches,statements}=0 overrides to the Run tests with coverage step.
Apply the same overrides to Generate Coverage Report (JSON/HTML) and convert the run line to multi-line YAML form.
Add explanatory comments clarifying that these are report-only steps and that real gates live elsewhere.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cubic-dev-ai

No issues found across 1 file

_{Re-trigger cubic}

adm01-debug · 2026-05-15T17:58:49Z

Fechando como redundante: descobri após investigação que o PR #227 (mergeado às 17:04 BRT, 14 minutos antes deste PR ser aberto) já aplicou byte-por-byte o mesmo fix de thresholds CLI nos 2 jobs report-only.

Comparei main (HEAD 0e61eeac1) com este branch e o diff mostra que mergear este PR não só seria duplicado para o threshold fix — ele REGREDIRIA 3 outras melhorias do PR #227:

Removeria o step novo Enforce Critical Modules Coverage (per-file gate) no job coverage
Voltaria Enforce Critical Coverage para o job critical-e2e (onde estava quebrado por falta de coverage instrumentation no Playwright)
Reverteria o path do theme-validation-data.json (playwright-report/ → theme-validation-output/)

Confirmação de que o bug original foi corrigido: run 25931978144 no main HEAD passou com 11/11 jobs verdes, incluindo o Edge Integration & Fuzzing (job do link original) e Test Coverage.

Causa-raiz da duplicação: instâncias paralelas de Claude trabalhando no mesmo repo sem coordenação. O git pull origin main --ff-only que fiz no início da sessão (16:11 BRT) ficou stale quando PR #227 mergeou às 17:04 — depois eu pushei às 17:17 sem revalidar. Lição: re-pull imediatamente antes do push, mesmo em sessões curtas.

Branch será deletada.

Copilot AI review requested due to automatic review settings May 15, 2026 16:18

vercel Bot deployed to Preview May 15, 2026 16:18 View deployment

Copilot started reviewing on behalf of adm01-debug May 15, 2026 16:18 View session

Copilot AI reviewed May 15, 2026

View reviewed changes

cubic-dev-ai Bot reviewed May 15, 2026

View reviewed changes

adm01-debug closed this May 15, 2026

adm01-debug deleted the fix/ci-coverage-report-thresholds branch May 15, 2026 17:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ci): zerar thresholds CLI em report-only coverage jobs (close 25925328625)#228

fix(ci): zerar thresholds CLI em report-only coverage jobs (close 25925328625)#228
adm01-debug wants to merge 1 commit into
mainfrom
fix/ci-coverage-report-thresholds

adm01-debug commented May 15, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented May 15, 2026 •

edited

Loading

Uh oh!

supabase Bot commented May 15, 2026

Uh oh!

coderabbitai Bot commented May 15, 2026 •

edited

Loading

Review ran into problems

Uh oh!

Copilot AI left a comment

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

adm01-debug commented May 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

adm01-debug commented May 15, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problema

Por que esses 2 jobs não deveriam aplicar threshold global

Fix

Validação local

Escopo

Não corrigido (pendências pré-existentes confirmadas, NÃO regressão deste PR)

Summary by cubic

Summary by CodeRabbit

Uh oh!

vercel Bot commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

supabase Bot commented May 15, 2026

Uh oh!

coderabbitai Bot commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Review ran into problems

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

adm01-debug commented May 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

adm01-debug commented May 15, 2026 •

edited by coderabbitai Bot

Loading

vercel Bot commented May 15, 2026 •

edited

Loading

coderabbitai Bot commented May 15, 2026 •

edited

Loading