chore(db): drop 17 duplicate/no-op migrations to unblock Supabase Preview gate#230
Conversation
…ack_functions_fix_view_security.sql (1/17)
…cision.sql (2/17)
…ation_rls.sql (3/17)
…_tables.sql (4/17)
…_email_like_admin_policies.sql (5/17)
…sor_violations.sql (6/17)
…ency_and_security.sql (7/17)
…ge_function_secret_acl.sql (8/17)
…ns_idempotent.sql (9/17)
…_members_public.sql (10/17)
…ser_organizations.sql (11/17)
…id_definitive.sql (12/17)
…ression_and_bilateral_gate.sql (13/17)
…ng_final.sql (14/17)
…p_orphans_uuid_only.sql (15/17)
…ecalc_subtotal_completo.sql (16/17)
…tements.sql (17/17)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Updates to Preview Branch (cleanup/delete-16-duplicate-migrations) ↗︎
Tasks are run on every commit but only new migration files are pushed.
❌ Branch Error • Fri, 15 May 2026 18:33:49 UTC View logs for this Workflow Run ↗︎. |
There was a problem hiding this comment.
Pull request overview
Deletes 17 migration files from supabase/migrations/ that conflict with the Supabase Preview gate. The gate has been failing since 2026-05-14 with "Remote migration versions not found in local migrations directory" because these files have timestamps that diverge from what was actually applied to production (other sessions applied DDL via apply_migration with different timestamps and never cleaned the git copies). Per the repo convention, supabase/migrations is legacy history and Supabase DB is the source of truth, so dropping these files is the standard remediation.
Changes:
- Removes 6 migrations that are exact
md5duplicates of already-applied prod migrations (different timestamps). - Removes 2 migrations whose effects were already applied to prod via different (split or hardcoded) migrations.
- Removes 9 migrations whose target objects already exist in prod (no-ops if replayed) or describe schema drift that is intentionally not being aligned (e.g., multi-tenant
organization_idrollout, profilesuser_idreshape).
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
20260514000000_fix_policy_idempotency_and_security.sql |
Exact duplicate of applied 20260514200725_*. |
20260514230000_onda16_drop_legacy_email_like_admin_policies.sql |
Exact duplicate of applied 20260514233703_*. |
20260515000000_onda17_fn_quotes_recalc_subtotal_completo.sql |
Exact duplicate of applied 20260514235639_*. |
20260515030000_onda19_numeric_precision.sql |
Exact duplicate of applied 20260515020250_*. |
20260515040000_onda19_followup_track_functions_fix_view_security.sql |
Exact duplicate of applied 20260515103945_*. |
20260515120000_fix_audit_ownership_orphans_uuid_only.sql |
Exact duplicate of applied 20260515124035_*. |
20260515010000_onda18a_quote_isolation_rls.sql |
Functionally equivalent; prod applied via 3 split migrations. |
20260515020000_onda18b_backfill_user_organizations.sql |
Backfill already executed in prod via 20260515005356. |
20260512210001_enable_pg_stat_statements.sql |
Extension already enabled in prod. |
20260514000001_t38_deploy_hardening_final.sql |
Hardening already applied in prod (ACLs match). |
20260514000002_t39_create_missing_tables.sql |
All 12 tables already exist in prod. |
20260515123000_t40b_harden_get_edge_function_secret_acl.sql |
ACL already correct in prod. |
20260515130000_revoke_org_has_any_members_public.sql |
ACL already correct in prod. |
20260515150000_onda20_fix_t38_regression_and_bilateral_gate.sql |
Function and ACLs already correct in prod. |
20260515040001_fix_profiles_user_id_definitive.sql |
Schema drift not being reconciled (profiles uses id). |
20250103180001_02_rls_organizations_idempotent.sql |
Multi-tenant rollout intentionally not applied (PromoGifts is single-tenant). |
20260515120000_t40_fix_error_advisor_violations.sql |
All 10 referenced tables/views do not exist in prod (no-op). |
A few caveats worth flagging for human review (rather than blocking comments — they apply to the PR as a whole rather than to a specific changed line):
supabase db reset/ fresh-environment behaviour. Several deleted files (notablyt39_create_missing_tables,t38_deploy_hardening_final,onda20_fix_t38_regression_and_bilateral_gate, theonda17/18a/18b/19set) created tables, hardening functions, RLS policies and triggers that other migrations may reference. After this PR asupabase db resetfrom migrations alone would no longer rebuild that state. The PR description acknowledges this is acceptable since prod is the source of truth, but it's worth confirming that no Preview/CI flow attempts a from-scratch replay.- Replacement coverage in repo. A few of the "already applied in prod via different timestamp" cases (e.g., the
onda18aREVOKE/GRANT split into20260515010528/010546/013126, theonda16storage policy work via20260513040959_*) rely on those replacement files being present insupabase/migrations/. Worth a quick check that nothing was orphaned. 20260515040001_fix_profiles_user_id_definitive.sqlis the one deletion that is not a duplicate or no-op — it would actively change schema. Deleting is fine given the description's rationale, but this is the file whose removal is most consequential if the analysis is wrong.
I haven't found objective issues in the diff itself (it's pure deletion of files whose forensic justification is documented), but the operational risk and reliance on out-of-band md5/ACL/object-existence verification put this above the bar for automated approval.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (17)
💤 Files with no reviewable changes (17)
WalkthroughEste PR remove integralmente 16 migrações SQL acumuladas entre janeiro e maio de 2026. As remoções impactam hardening de SECURITY DEFINER, políticas RLS, funções de auditoria, criação de tabelas críticas, triggers de recálculo de quotes, monitoramento de performance e ajustes de índices/autovacuum. É essencialmente um revert massivo de hardening e funcionalidade de banco de dados. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutos Justificativa: 16 migrações SQL removidas com impacto cruzado (segurança, RLS, audit, tabelas, triggers, hardening ACL). Requer análise de cada cluster (hardening SECURITY DEFINER, isolamento de quotes, tabelas críticas, monitoramento) para entender se é revert intencional ou erro. Alto risco de regressão de segurança e funcionalidade em produção. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 507b94ef19
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ALTER TABLE public.quotes | ||
| ALTER COLUMN discount_percent TYPE numeric(5,2), | ||
| ALTER COLUMN negotiation_markup_percent TYPE numeric(5,2), | ||
| ALTER COLUMN real_discount_percent TYPE numeric(5,2); |
There was a problem hiding this comment.
Deleting this migration leaves the repository with only the placeholder 20260515020250_applied_to_production.sql for the production-applied version, and that file contains no executable SQL. Any fresh Supabase Preview/local database that replays the local migrations will therefore skip these ALTER TABLE statements, so money/discount columns like quotes.real_subtotal and quotes.discount_percent keep their old unconstrained numeric definitions while production has the bounded (10,2)/(5,2) schema; tests can pass against a schema that accepts values production rounds/rejects, reintroducing the schema drift this migration was meant to close. Please keep the actual SQL under the production timestamp instead of replacing it with a stub/deleting the only executable copy.
Useful? React with 👍 / 👎.
| GRANT EXECUTE ON FUNCTION public.can_access_quote(uuid) TO authenticated, service_role; | ||
|
|
||
| -- 2. QUOTES - SELECT + UPDATE | ||
| DROP POLICY IF EXISTS "org_members_view_quotes" ON public.quotes; |
There was a problem hiding this comment.
Removing this migration leaves the older org_members_view_quotes policy from 20250103020000_rls_organizations.sql in place on fresh Preview/local databases; I searched the migrations and this deleted statement is the only later drop of that policy. Because Postgres combines permissive RLS policies with OR semantics, that old policy still lets any authenticated member of the organization select every quote in the org, bypassing the seller-only scope that this migration introduces for vendedor/agente users. Keep this SQL under the production-applied timestamp rather than replacing it with empty placeholder files.
Useful? React with 👍 / 👎.
| -- Caso 4 (NOVO — Onda 20): usada em policy mas authenticated sem EXECUTE | ||
| -- Caller authenticated falha com `42501: permission denied for function` | ||
| -- ao avaliar a RLS policy. Detecta o anti-padrão que quebrou prod | ||
| -- via PR #192 (t38). | ||
| SELECT | ||
| pu.proname, | ||
| pu.args, | ||
| 'used in RLS policy but missing EXECUTE for authenticated (RLS will fail with 42501)'::text, | ||
| 'authenticated (MISSING)'::text | ||
| FROM policy_uses pu | ||
| WHERE NOT EXISTS ( | ||
| SELECT 1 FROM acl_expanded a | ||
| WHERE a.oid = pu.oid AND a.grantee = 'authenticated' | ||
| ) |
There was a problem hiding this comment.
Deleting this replacement leaves fresh Preview/local databases with the older audit_security_definer_acl() from 20260427114657_060d4634-693c-4d21-980e-e448d7166307.sql, which only checks PUBLIC/anon/trigger grants. The CI script scripts/check-security-definer-acl.mjs calls this RPC, so without this deleted policy_uses branch it will no longer catch SECURITY DEFINER helpers used by RLS policies but missing EXECUTE for authenticated—the exact regression documented here as causing 42501 failures. Keep this SQL under the production-applied timestamp instead of replacing it with an empty placeholder.
Useful? React with 👍 / 👎.
Contexto
O gate Supabase Preview falha desde 14/mai/2026 com erro "Remote migration versions not found in local migrations directory".
Causa-raiz: o git contém migrations que não existem em prod por timestamp idêntico, criando "out-of-order detection" no Supabase CLI. Outras sessões de Claude criaram arquivos no git com timestamp X, aplicaram em prod via apply_migration (timestamp Y diferente), e nunca limparam o arquivo do git.
Validação executada (análise forense sem mexer em prod)
6 migrations com canon md5 IDÊNTICO entre git e prod (duplicatas exatas)
2 migrations funcionalmente equivalentes (mesmo efeito final)
9 migrations cujos objetos JÁ EXISTEM em prod (no-op se aplicadas)
20260512210001_enable_pg_stat_statements— extensão habilitada20260514000001_t38_deploy_hardening_final— ACLs is_admin_or_above/is_coord_or_above corretas20260514000002_t39_create_missing_tables— 12/12 tabelas existem20260515123000_t40b_harden_get_edge_function_secret_acl— ACL correta (postgres+service_role)20260515130000_revoke_org_has_any_members_public— ACL correta20260515150000_onda20_fix_t38_regression_and_bilateral_gate— função existe + ACLs corretas20260515040001_fix_profiles_user_id_definitive— profiles funciona com id (8 rows, 2 policies); migration faria mudança de schema sem benefício20250103180001_02_rls_organizations_idempotent— schema drift: só 5/17 tabelas têm organization_id; PromoGifts é sistema interno20260515120000_t40_fix_error_advisor_violations— (17º arquivo achado durante operação) todas as 10 tabelas/views NÃO existem em prod (client_contacts, webhook_, v_); idempotente, no-opNota de processo
Durante a execução, commit df5884f deletou um arquivo direto no main por engano (parâmetro branch ausente no MCP github_delete_file). Restaurado imediatamente via e5916d3. Histórico do main preserva ambos (delete+revert se cancelam funcionalmente). Memória atualizada com guardrail.
Resultado esperado
Rollback
Se Supabase Preview continuar falhando após merge, basta reverter este PR — nenhuma mudança em prod foi feita.
Summary by cubic
Dropped 17 duplicate or no-op database migration files to unblock the Supabase Preview gate. Repo-only cleanup; production schema and data stay the same.
supabase/migrationswith applied versions.Written for commit 507b94e. Summary will update on new commits. Review in cubic
Summary by CodeRabbit
Notas de Lançamento