lint: mechanical sweep — merge duplicate imports, allow empty catch, fix ternary statements

[adm01-debug]

Summary

Mechanical ESLint sweep — reduces problem count by another ~120 (1939 → 1820 total; 1430 → 1308 errors). Builds on the cleanup roadmap from PR #29.

What changed

scripts/codemod-merge-duplicate-imports.mjs (new)

One-shot codemod that fixes no-duplicate-imports by merging multiple import statements targeting the same module, with full TS-awareness:

• Value + value imports merge into one statement
• Type-only + type-only merge into one import type ... statement
• Type-only + value imports fold the type-only specs as inline type specifiers — e.g. import { type LucideIcon, ChevronRight } from "lucide-react"
• Default + namespace + named all preserved correctly
• --check mode for CI gate

Result: 92 of 93 mergeable cases auto-resolved across 99 files. The remaining 1 case is a top-level import type Default from ... which has no inline-type syntax equivalent.

eslint.config.js — allowEmptyCatch

'no-empty': ['error', { allowEmptyCatch: true }]

Empty catches in this codebase are idiomatic "best-effort, swallow failures" (e.g. localStorage writes that may be quota-exceeded). They don't hide bugs the way empty if/else/loop blocks do. Eliminates 23 false-positive errors.

8 manual fixes for @typescript-eslint/no-unused-expressions

• 6× ternary-as-statement cond ? a() : b() → if/else form
• 2× malformed scrollTo?.(...) ?? fallback — the optional chain always returned undefined so the fallback always ran. Actual bug masquerading as a lint warning — fixed with proper if (typeof scrollTo === 'function') branching.

1 manual fix in useProductSupplierSources.ts:81

The only non-catch empty block in the codebase. Inverted the condition into if (!isDuplicate) for readability.

Validation

Check	Before	After
eslint src --max-warnings=500 (problems)	1939	1820
eslint src --max-warnings=500 (errors)	1430	1308
no-duplicate-imports violations	93	1
no-empty violations	24	0
@typescript-eslint/no-unused-expressions	8	0
npx tsc --noEmit	exit 0	exit 0
npm run test failing files	9 (pre-existing, see PR #28)	9 (same)

No new test regressions. The 8 ternary→if/else changes preserve semantics exactly; the 2 scrollTo fixes are net-positive (the original code was buggy).

Test plan

• npx tsc --noEmit passes
• npm run test — same pre-existing failure set (PR test: fix 9 drifted test files; suite is now 100% green #28 covers them)
• node scripts/codemod-merge-duplicate-imports.mjs --check exits 0
• After merge: bake into CI as npm run lint:check:imports style

https://claude.ai/code/session_01KWeDG

---

Generated by Claude Code

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7c9d902a-bbdf-4679-99bb-ef0ed68e9da0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/eslint-mechanical-sweep

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}