lint: convert 24 'catch (e: any)' to 'catch (e: unknown)'#50
Closed
adm01-debug wants to merge 1 commit into
Closed
lint: convert 24 'catch (e: any)' to 'catch (e: unknown)'#50adm01-debug wants to merge 1 commit into
adm01-debug wants to merge 1 commit into
Conversation
The 'catch' clause type defaults to 'unknown' in TypeScript 4.4+, which is the canonical typing — it forces the catch body to narrow the error before accessing .message / .stack, surfacing real bugs where consumers assumed an Error shape on a thrown non-Error value. Hand-verified: tsc --noEmit passes, meaning every consumer of these catch bindings already handles 'unknown' correctly (typically via 'err instanceof Error ? err.message : String(err)'). ## Files touched (15) src/components/admin/ImageUploadButton.tsx (1) src/components/admin/users/useUserManagement.ts (4) src/components/admin/products/video-gallery/useProductVideoGallery.ts (1) src/components/admin/security/SecureUploadManager.tsx (2) src/components/magic-up/PromptGenerator.tsx (1) src/components/quotes/QuoteConvertToOrder.tsx (1) + 9 others (one occurrence each) ## Validation no-explicit-any 273 → 249 (−24) tsc --noEmit exit 0 (all consumers narrow correctly) tests no regressions (90 baseline failures)
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
R5.3 — converts 24
catch (e: any)clauses tocatch (e: unknown)across 15 files.The catch-clause type defaults to
unknownin TypeScript 4.4+, which is the canonical typing — it forces the catch body to narrow the error before accessing.message/.stack, surfacing real bugs where consumers assumed anErrorshape on a thrown non-Errorvalue.Why this is safe
tsc --noEmitpasses. That means every consumer of these catch bindings already handlesunknowncorrectly — typically via:If any consumer were doing
err.messagedirectly, TypeScript would have errored out. None did.Files touched (15)
src/components/admin/ImageUploadButton.tsxsrc/components/admin/users/useUserManagement.tssrc/components/admin/products/video-gallery/useProductVideoGallery.tssrc/components/admin/security/SecureUploadManager.tsxsrc/components/magic-up/PromptGenerator.tsxsrc/components/quotes/QuoteConvertToOrder.tsxValidation
no-explicit-anytsc --noEmitnpm run testWhat's still left in
no-explicit-any: anyannotations: any[]arraysRecord<string, any>as anycasts<any>generics[key: string]: anyindex sigsPromise<any>https://claude.ai/code/session_01KWeDG
Generated by Claude Code