lint: re-apply unused-vars codemod against current main (518 → 67)#55
Closed
adm01-debug wants to merge 1 commit into
Closed
lint: re-apply unused-vars codemod against current main (518 → 67)#55adm01-debug wants to merge 1 commit into
adm01-debug wants to merge 1 commit into
Conversation
Same logic as PR #37, re-applied against current main since #37 hasn't merged yet. Idempotent: if both PRs land, second is a no-op. ## Edits applied imports 298 Removed unused named/default imports (drop full line if brace becomes empty) destructure 67 Renamed unused destructured locals to '_name' locals 47 Renamed unused 'const'/'let' locals to '_name' params 45 Renamed unused function args to '_name' skipped 61 Already-prefixed (_name) or locator failed TOTAL 457 transforms across 269 files ## Remaining 67 cases Destructured object args inside multi-line function signatures (e.g. 'function VideoGrid(\{ filteredVideos, variantMap, ... \})') — renaming would change the destructure target name and break the binding. Proper fix is aliasing ('\{ variantMap: \_variantMap \}') which is too case-by-case for a regex codemod. ## Validation no-unused-vars 518 → 67 violations tsc --noEmit exit 0 tests no regressions
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
R7.2 — re-applies the unused-vars codemod from PR #37 against current
main. 457 transforms across 269 files. Idempotent with PR #37 (if both merge, second is a no-op).no-unused-varstsc --noEmitnpm run testEdits applied
{ unused }→{ _unused }(safer than removal: siblings may be used)const x→const _x(RHS may have side effects)(x) =>→(_x) =>(preserves arity)What's left (67 cases)
Destructured object args inside multi-line function signatures:
Renaming
variantMap→_variantMapwould change the destructure target name and break the binding. Proper fix is aliasing ({ variantMap: _variantMap }) which is too case-by-case for a regex codemod.https://claude.ai/code/session_01KWeDG
Generated by Claude Code