fix(smoke): remove 7 rotas publicas mortas do REQUIRED_ROUTES#94
Conversation
As rotas /approve/:token, /proposta/:token, /kit/:token, /lista-publica/:token, /colecao-publica/:token, /comparar-publica/:token e /dossie/:token foram removidas do App.tsx no commit 0bc9775. O scripts/smoke-tests.mjs nao foi atualizado nesse commit, entao o smoke test falhou desde entao em CI verificando rotas que nao existem mais. Apos este fix, REQUIRED_ROUTES contem apenas as 7 rotas que de fato existem em App.tsx (validado contra o estado atual da main). Validacao local: node scripts/smoke-tests.mjs -> exit 0 -> 1 ok / 2 warn (vars de ambiente nao setadas, esperado em local) -> 0 fail Refs: F1-6.x (post-cleanup das 7 rotas publicas)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning
|
| Layer / File(s) | Summary |
|---|---|
Route Validation Scope scripts/smoke-tests.mjs |
REQUIRED_ROUTES constant reduced by removing seven tokenized public routes from the static-route check. Health-check and public-route checks remain unchanged. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
🐰 A rabbit hops through smoke tests fine,
Routes trimmed from the old design,
Seven paths now left behind,
Validation lighter, simpler—divine! ✨
Note
🎁 Summarized by CodeRabbit Free
Your organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.If you believe this is a mistake and have available seats, please assign one to the pull request author through the subscription management page using the link above.
Comment @coderabbitai help to get the list of available commands and usage tips.
There was a problem hiding this comment.
Pull request overview
Atualiza o smoke test de CI para parar de validar 7 rotas públicas por token que já não existem mais no roteador (src/App.tsx), eliminando falhas falsas no pipeline.
Changes:
- Remove 7 entradas obsoletas do array
REQUIRED_ROUTESemscripts/smoke-tests.mjs. - Faz o check estático de rotas refletir apenas as rotas críticas ainda declaradas em
src/App.tsx.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Promo_Gifts/scripts/smoke-tests.mjs
Line 32 in 34e7e6d
Keep smoke coverage for generated public links
Removing these public-token routes from REQUIRED_ROUTES hides a live user-facing breakage: the app still generates and copies URLs under these paths, e.g. ShareListDialog builds /lista-publica/${list.shared_token}, ShareCollectionDialog builds /colecao-publica/..., and ShareComparisonDialog builds /comparar-publica/.... Since those routes are no longer declared in App.tsx, users who use the share dialogs get links that fall through to the 404; the smoke test should keep failing until the remaining link generators are removed/disabled or the routes are restored.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
CONTEUDO ======== 1. docs/AUDITORIA_2026-05-07.md atualizado: - Status Fase 1: 12/15 (80%) -> 16/19 (84%) - Adicionada secao 1.7 Paginas orfas (F1-7.1 a F1-7.12) - Adicionada secao 1.8 Quick-wins infra (F1-8.1 a F1-8.5) - Changelog v1.3 com sumario dos 4 PRs 2. docs/HANDOFF-2026-05-07-SESSAO-NOITE.md NOVO: - Handoff suplementar pra proxima instancia - Resumo: o que foi feito, o que ficou versionado - Achados bonus pendentes (F1-7.11, F1-7.12) - Estado atual dos gates (validar no inicio da proxima sessao) - Checklist de primeira acao - Proximas opcoes estrategicas CONTEXTO ======== Sessao de noite mergeou 4 PRs em sequencia consertando infra de CI e fazendo a primeira faxina propriamente dita: - PR #94 (5a3c7f5) fix smoke-tests - PR #95 (dd33143) regenera baseline ESLint, versiona F5-3.3 - PR #96 (9402fda) alinha pre-push hook, versiona F5-3.5 - PR #97 (741af39) deleta 4 paginas orfas (-1139 linhas) GOVERNANCA ========== Mudanca Pequena (2 arquivos, ~200 linhas) -> merge direto na main. Atende ao pedido do Joaquim: 'deixe bem documentado o que ja fizemos, assim se eventualmente o chat chegar em seu limite, o proximo agente Claude vai conseguir continuar a faxina'. REFS ==== - F1-7, F1-8, F5-3.3, F5-3.5 versionadas - Sessao da tarde: docs/HANDOFF-2026-05-07.md (intacto) - Sessao de noite: docs/HANDOFF-2026-05-07-SESSAO-NOITE.md (NOVO)
Contexto
As 7 rotas publicas com token foram removidas do
App.tsxno commit0bc97759b(Fase 1 da auditoria). Mas oscripts/smoke-tests.mjsnao foi atualizado nesse commit, entao o smoke check de CI falha desde entao verificando rotas inexistentes.O que muda
scripts/smoke-tests.mjs: remove 7 entries do arrayREQUIRED_ROUTES:/approve/:token/proposta/:token/kit/:token/lista-publica/:token/colecao-publica/:token/comparar-publica/:token/dossie/:tokenResultado:
REQUIRED_ROUTESreflete o que de fato existe emApp.tsx.Validacao local
Os 2 warns sao porque envvars nao estao setadas em ambiente local; em CI elas estao e os checks rodam normalmente.
Tamanho
1 arquivo, -7 linhas.
Refs
0bc97759bSummary by CodeRabbit