Skip to content

chore(cleanup): remove cluster orfao useProductRegistration* (F1-7.11)#98

Merged
adm01-debug merged 2 commits into
mainfrom
chore/cleanup-cluster-product-registration-hooks
May 8, 2026
Merged

chore(cleanup): remove cluster orfao useProductRegistration* (F1-7.11)#98
adm01-debug merged 2 commits into
mainfrom
chore/cleanup-cluster-product-registration-hooks

Conversation

@adm01-debug
Copy link
Copy Markdown
Owner

@adm01-debug adm01-debug commented May 8, 2026

Em portugues claro pro Joaquim

Problema: durante o PR #97 descobri 3 hooks que NAO eram importados por ninguem fora do proprio cluster — orfaos sobreviventes da `ProductRegistrationPage` que ja deletei. Este PR limpa essa sobra.

Solucao: apaga os 3 hooks (-513 linhas) + remove secao 3.4 do doc `FUNCIONALIDADES` que apontava pra eles.

Topologia do cluster (validada)

```
useProductRegistration --> (so importado por useBulkImportFile)
useBulkImportFile --> (NINGUEM importa)
useProductRegistrationImport --> (NINGUEM importa)
```

Todos os 3 sao filhos da `ProductRegistrationPage.tsx` deletada no PR #97 (commit `741af39aa`).

Arquivos alterados

Arquivo Linhas O que muda
`src/hooks/useProductRegistration.ts` -228 Deletado (cluster orfao)
`src/hooks/useBulkImportFile.ts` -157 Deletado (cluster orfao)
`src/hooks/useProductRegistrationImport.ts` -128 Deletado (cluster orfao)
`docs/FUNCIONALIDADES_E_FERRAMENTAS.md` -5 / +0 Secao 3.4 inteira removida + renumera 3.5-3.12 -> 3.4-3.11
`docs/AUDITORIA_2026-05-07.md` F1-7.11/12 marcadas como concluidas; Fase 1 84% -> 95%
Total 5 arquivos, -518 linhas

Validacoes

Check Resultado
TypeCheck ✅ 0 erros (2s)
ESLint baseline ✅ 1564 / 1571 — 7 erros eliminados (drift positivo)
Pre-push hook ✅ passou sem `--no-verify`

Red team antes de executar

Cobri os mesmos vetores do PR #97:

Bug encontrado durante execucao: minha primeira tentativa de renumeracao do FUNCIONALIDADES pulou seções 3.10-3.12 (passei na 3.9 e parei). Detectei e corrigi no proprio commit antes do push.

Risco

Vetor Avaliacao
Producao Zero (cluster sem importadores externos)
Build Sem testar — typecheck ja confirma absência de quebra
TypeCheck ✅ Validado
Reversao `git revert`

Refs

Summary by CodeRabbit

  • Removed Features

    • Removed product registration and bulk import functionality (CSV/XLSX upload and mapping capabilities).
  • Documentation

    • Reorganized product management documentation structure.
    • Updated project milestone tracking—Phase 1 progress advanced to 18/19 completed tasks.

Cluster fechado de 3 hooks que NAO eram importados por ninguem fora do
proprio cluster. Eram filhos da ProductRegistrationPage.tsx, deletada
no PR #97 (commit 741af39).

TOPOLOGIA DO CLUSTER (validada via grep recursivo):
- useProductRegistration.ts (228 linhas) - exportava PRODUCT_FIELDS,
  BulkImportRow, ColumnMapping. Importado APENAS por useBulkImportFile.
- useBulkImportFile.ts (157 linhas) - logica de import em massa.
  ZERO importadores externos.
- useProductRegistrationImport.ts (128 linhas) - 'logica de importacao'.
  ZERO importadores externos.

VALIDACAO PREVIA:
- grep recursivo em src/, scripts/, e2e/, supabase/ (.ts, .tsx, .json,
  .md, .mjs, .js, .html) → zero refs externas
- zero imports dinamicos (lazy, import())
- zero tests/specs/stories
- pagina que usava (ProductRegistrationPage) ja morta no PR #97

Arquivos removidos: 3 (513 linhas)
Refs auditoria: F1-7.11
MUDANCAS
========
1. docs/FUNCIONALIDADES_E_FERRAMENTAS.md
   - Secao 3.4 'Registro de Produtos' removida inteira (apontava
     pro hook deletado no commit anterior)
   - Renumeracao em cascata: 3.5->3.4, 3.6->3.5, 3.7->3.6, 3.8->3.7,
     3.9->3.8, 3.10->3.9, 3.11->3.10, 3.12->3.11
   - Sequencia 3.1 a 3.11 sem buracos

2. docs/AUDITORIA_2026-05-07.md
   - F1-7.11 marcada como CONCLUIDA (cluster useProductRegistration*)
   - F1-7.12 marcada como CONCLUIDA (secao 3.4 removida)
   - Contador da Fase 1: 16/19 (84%) -> 18/19 (95%)

REFS
====
- F1-7.11, F1-7.12 (versionados em 07/05/2026 sessao de noite)
- Resolve achado bonus do PR #97
Copilot AI review requested due to automatic review settings May 8, 2026 11:43
@vercel
Copy link
Copy Markdown

vercel Bot commented May 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
promo-gifts Ready Ready Preview, Comment May 8, 2026 11:43am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 8, 2026

Review Change Stack

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: String must contain at most 250 character(s) at "tone_instructions"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Free

Run ID: c6382565-b2d7-4811-a228-04103600a715

📥 Commits

Reviewing files that changed from the base of the PR and between 63a630e and dc155a8.

📒 Files selected for processing (5)
  • docs/AUDITORIA_2026-05-07.md
  • docs/FUNCIONALIDADES_E_FERRAMENTAS.md
  • src/hooks/useBulkImportFile.ts
  • src/hooks/useProductRegistration.ts
  • src/hooks/useProductRegistrationImport.ts
💤 Files with no reviewable changes (3)
  • src/hooks/useProductRegistration.ts
  • src/hooks/useBulkImportFile.ts
  • src/hooks/useProductRegistrationImport.ts

📝 Walkthrough

Walkthrough

This PR completes the cleanup of the product registration feature by removing three orphaned React hooks and updating documentation. The hooks (useBulkImportFile, useProductRegistration, useProductRegistrationImport) are deleted entirely, along with all associated types, interfaces, and implementations. Audit and feature documentation are updated to reflect task completion and section renumbering.

Changes

Product Registration Feature Cleanup

Layer / File(s) Summary
Audit & Feature Documentation
docs/AUDITORIA_2026-05-07.md, docs/FUNCIONALIDADES_E_FERRAMENTAS.md
Audit task counter increments from 16/19 to 18/19. Product registration section is removed from feature documentation; remaining sections (3.4–3.11) are renumbered sequentially.
Removed Type Definitions and Exports
src/hooks/useBulkImportFile.ts, src/hooks/useProductRegistration.ts, src/hooks/useProductRegistrationImport.ts
Removed exported types: ImportMode, ImportStep, ParsedData, ProductFormData, ProductImageInput, BulkImportRow, ImportValidationResult, ColumnMapping. Removed hooks: useBulkImportFile(), useProductRegistration(), useProductImport(). Removed field descriptor: PRODUCT_FIELDS.
useBulkImportFile Hook Removal
src/hooks/useBulkImportFile.ts
Parsing logic for CSV/XLSX files via papaparse and dynamic XLSX import, column mapping utilities for field matching and transformation, and file input/drag-and-drop event handlers deleted.
useProductRegistration Hook Removal
src/hooks/useProductRegistration.ts
Module imports, reference-data loading via parallel fetches for categories/suppliers/techniques/tags, product and image creation logic, audit log insertion, toast notifications, and delegation to import helper deleted.
useProductImport Hook Removal
src/hooks/useProductRegistrationImport.ts
Import progress state management, row validation including numeric parsing and supplier/category ID resolution, sequential product import with per-row error handling, progress tracking, success/error toast notifications, and CSV template generation with browser download deleted.

🎯 4 (Complex) | ⏱️ ~45 minutes

🐰 A cluster cleaned with care,
Three hooks that once thrived in the air,
Now pass into rest,
Their purpose addressed,
The code breathes again, fresh and fair! 🌿


Note

🎁 Summarized by CodeRabbit Free

Your organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.If you believe this is a mistake and have available seats, please assign one to the pull request author through the subscription management page using the link above.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Remove um “cluster órfão” de hooks relacionado ao antigo fluxo de registro/importação de produtos (já desativado com a remoção da ProductRegistrationPage no PR #97), e atualiza a documentação/auditoria para refletir essa limpeza.

Changes:

  • Remove 3 hooks não referenciados (useProductRegistration*) que só se importavam entre si.
  • Remove a seção correspondente no doc de funcionalidades e renumera as subseções seguintes.
  • Atualiza a auditoria para marcar as tarefas F1-7.11 e F1-7.12 como concluídas (e ajustar o percentual da Fase 1).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/hooks/useProductRegistration.ts Deleta hook órfão de cadastro de produto (inclui tipos/export PRODUCT_FIELDS).
src/hooks/useBulkImportFile.ts Deleta hook órfão de parsing/mapping de arquivo de importação em massa.
src/hooks/useProductRegistrationImport.ts Deleta hook órfão de validação/importação de linhas e geração de template CSV.
docs/FUNCIONALIDADES_E_FERRAMENTAS.md Remove seção “Registro de Produtos” e renumera as seções 3.4+ mantendo a formatação consistente.
docs/AUDITORIA_2026-05-07.md Marca F1-7.11/F1-7.12 como concluídas e ajusta progresso da Fase 1.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adm01-debug adm01-debug merged commit a058489 into main May 8, 2026
13 of 21 checks passed
@adm01-debug adm01-debug deleted the chore/cleanup-cluster-product-registration-hooks branch May 8, 2026 11:51
adm01-debug added a commit that referenced this pull request May 8, 2026
CONTEUDO
========
1. docs/AUDITORIA_2026-05-07.md
   - Adicionada secao 3.0 'Triagem decisoria (concluida 07/05/2026)'
   - 7 decisoes registradas (F3-0.1 a F3-0.8)
   - 3 acoes pendentes do Joaquim (F3-0.9 a F3-0.11)
   - Status Fase 3: NAO INICIADA -> PRE-TRABALHO COMPLETO (8/11, 73%)
   - Changelog v1.4 (PR #98) e v1.5 (triagem) adicionados

2. docs/HANDOFF-2026-05-07-SESSAO-NOITE.md
   - Resumo de uma frase atualizado (84% -> 95%, 5 PRs)
   - Nova secao 'Triagem decisoria da Fase 3'
   - Premissa-chave revelada: sistema NAO em producao real
   - Tabela proximas opcoes atualizada (A e B marcadas concluidas)
   - F3-0.9 a F3-0.11 documentadas como bloqueadores

PREMISSA-CHAVE REVELADA NA SESSAO
==================================
Joaquim confirmou explicitamente: o sistema NAO esta em producao real.
Todos os dados existentes sao de teste. Isso simplificou as 7 decisoes
drasticamente (descartar historico = zero impacto).

DECISOES REGISTRADAS
====================
1. admin_audit_log_*       -> DESCARTA (a)
2. product_views          -> CONTINUA (a)
3. Expert IA              -> CONTINUA (a)
4. MFA step-up            -> DESCARTA (b)
5. Bitrix24               -> CONTINUA (a)
6. ai_usage_*             -> CONTINUA (a)
7. Voz / Voice Agent      -> CONTINUA (a)

EFEITOS COLATERAIS NOTAVEIS
============================
- 3 integracoes pagas continuam ativas: API IA, ElevenLabs, Bitrix24
- ai_usage (#6) protege contra explosao de custos das outras 3
- 2 recomendacoes minhas foram contrariadas (#5, #7) — decisao do Joaquim vale

PROXIMOS PASSOS
===============
Pra DESBLOQUEAR execucao da Fase 3, Joaquim precisa:
- F3-0.9: transferir Supabase Lovable pra conta propria (3 cliques)
- F3-0.10: enable_signup = false no painel
- F3-0.11: enable_anonymous_sign_ins = false no painel

GOVERNANCA
==========
Mudanca Pequena (2 arquivos docs, ~100 linhas) -> merge direto na main.

REFS
====
- F3-0.1 a F3-0.11 versionados
- Sessao da tarde: docs/HANDOFF-2026-05-07.md (intacto)
- Sessao de noite atualizada: docs/HANDOFF-2026-05-07-SESSAO-NOITE.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants