Skip to content

Conversation

@Govind-gupta75
Copy link
Contributor

No description provided.

@jardicc
Copy link
Collaborator

jardicc commented Jun 3, 2024

@Govind-gupta75 does it fix also automated testing via webdriver.io on Windows?

"cleanup": "node scripts/cleanup.js"
},
"cpu": [
"!arm64"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you may need to update the README here to reflect the change in arm support?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikemahony yes, I am working on fixing these.

@jardicc
Copy link
Collaborator

jardicc commented Jul 26, 2024

Could we have this not hard-coded please?

const args = [ "uxp-plugin-tests", testParams.driverPort, testParams.udtServicePort, testParams.supportedHostApp, testParams.uxpPluginID ];

It forces me to have uxp-plugin-tests script in parent package.json related to test files.

Maybe I would preffer to not have mandatory entry in my package.json.

Also is it possible to get rid off "yarn" dependency in order to run tests?

Copy link

@Idalis2fashion Idalis2fashion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@ErinFinnegan ErinFinnegan merged commit ef7e127 into adobe-uxp:main Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants