Skip to content

feat!: remove decorateButtons#199

Merged
fkakatie merged 5 commits intomainfrom
remove-decorate-buttons
Feb 19, 2026
Merged

feat!: remove decorateButtons#199
fkakatie merged 5 commits intomainfrom
remove-decorate-buttons

Conversation

@fkakatie
Copy link
Member

@fkakatie fkakatie commented Feb 5, 2026

Description

Remove decorateButtons from aem-lib. Button decoration has been migrated to boilerplate for better architectural separation.

Fixes #43

Related Issue

Companion to adobe/aem-boilerplate#585

Breaking Changes

The decorateButtons function has been completely removed.

Projects that manually update aem.js will experience import/call errors. See MIGRATION.md for:

  • What breaks
  • Three migration options (new implementation, old implementation, or remove)
  • Links to code examples

Motivation and Context

  • Button decoration touches styles and should live in editable boilerplate
  • Users are told not to modify aem.js but should feel empowered to customize buttons
  • Architectural separation: styling logic belongs in boilerplate, not shared library

How Has This Been Tested?

  • All existing tests pass
  • The removed function's tests were also removed as part of this change

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

BREAKING CHANGE: The decorateButtons function has been removed. See MIGRATION.md for upgrade instructions.

Ref: adobe/aem-boilerplate#585
@fkakatie fkakatie requested review from kptdobe and trieloff February 12, 2026 18:44
trieloff
trieloff previously approved these changes Feb 13, 2026
Copy link
Contributor

@trieloff trieloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The semantic commit messages look good and will create a breaking/major release for you.

Updated version number and removal date for migration guide.
@fkakatie fkakatie merged commit 16c57a0 into main Feb 19, 2026
3 checks passed
@fkakatie fkakatie deleted the remove-decorate-buttons branch February 19, 2026 16:10
@trieloff
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move decorateButtons to scripts.js?

2 participants