Skip to content

Add support for quickstart apps#679

Merged
purplecabbage merged 12 commits intomasterfrom
quick-start
Nov 13, 2023
Merged

Add support for quickstart apps#679
purplecabbage merged 12 commits intomasterfrom
quick-start

Conversation

@moritzraho
Copy link
Member

and --org --project flags

@purplecabbage purplecabbage marked this pull request as ready for review November 8, 2023 02:10
@codecov
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #679 (91e4783) into master (8863c0c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #679   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines         3188      3232   +44     
  Branches       599       611   +12     
=========================================
+ Hits          3188      3232   +44     
Files Coverage Δ
src/commands/app/init.js 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Member Author

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nit: we could remove the todos and commented code, up to you.

(I can't explicitly approve because I submitted the PR at first. So putting this emoji instead 🍏)

@MichaelGoberling MichaelGoberling self-requested a review November 13, 2023 21:01
@purplecabbage purplecabbage merged commit 19c916e into master Nov 13, 2023
@purplecabbage purplecabbage deleted the quick-start branch November 13, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants