update major for aio-cli-lib-app-config

[moritzraho]

Description

TO DISCUSS: potential breaking change because now every command that loads the configuration will undergo schema validation (via load in aio-cli-lib-app-config) and we may have some corner cases that were working without being valid

Depends on a release for adobe/aio-cli-lib-app-config#21 and adobe/aio-cli-lib-app-config#22

• async config
• no validation here, use aio-cli-lib-app-config instead.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[moritzraho]

Note tests are failing here but passing with local linking of aio-cli-lib-app-config

[shazron]

LGTM for code review - I haven't had a chance to test it by running the command yet, will do so next week

[moritzraho]

do not merge yet.
pre-release at @adobe/aio-cli-plugin-app@next
needs release of aio-cli-lib-app-config and updated package.json

[codecov]

Codecov Report

Merging #682 (fa423c2) into master (a7189d4) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #682   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         3152      3156    +4     
  Branches       589       589           
=========================================
+ Hits          3152      3156    +4     

Files Changed	Coverage Δ
src/BaseCommand.js	100.00% <100.00%> (ø)
src/commands/app/add/action.js	100.00% <100.00%> (ø)
src/commands/app/add/event.js	100.00% <100.00%> (ø)
src/commands/app/add/extension.js	100.00% <100.00%> (ø)
src/commands/app/add/web-assets.js	100.00% <100.00%> (ø)
src/commands/app/build.js	100.00% <100.00%> (ø)
src/commands/app/config/get/log-forwarding.js	100.00% <100.00%> (ø)
...c/commands/app/config/get/log-forwarding/errors.js	100.00% <100.00%> (ø)
src/commands/app/config/set/log-forwarding.js	100.00% <100.00%> (ø)
src/commands/app/delete/action.js	100.00% <100.00%> (ø)
... and 13 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[moritzraho]

postponed for now - needs a --no-config-validation flag

[moritzraho]

closing this for now as it is outdated

[purplecabbage]

instead of forcing a strict validation on every cli command, it might make more sense to just add a validate command and suggest developers run it if there is is an issue with config

[moritzraho]

For now let's just disable validation to move forward, see adobe/aio-cli-lib-app-config#32