Skip to content

Update AIO Libraries. Fixes #662 #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbradoschi merged 3 commits into from
Dec 19, 2022
Merged

Update AIO Libraries. Fixes #662 #664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
405b12d
chore(deps): updated dependencies to aio-lib-cloudmanager and aio-lib…
pahupe Dec 16, 2022
0256ff6
docs: updated docs
pahupe Dec 16, 2022
54f3094
chore(docs) update CONTRIBUTING docs in regards to forks and E2E tests
Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ node_modules
coverage/
junit.xml
.vscode/
.idea/
/package-lock.json
.aio
permissions.json
Expand Down
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ All submissions should come in the form of pull requests and need to be reviewed

Please follow the [pull request template](PULL_REQUEST_TEMPLATE.md) when submitting a pull request. Following the requirements for semantic releases (as described in the next section), each pull request should contain a single change and be comprised of a single commit.

**Pull requests created from forks won't be able to successfully run the E2E tests. We can’t use E2E secrets with workflows from a forked repository.**

## Error Handling

In order to ensure proper error handling, individual commands should generally *not* handle errors themselves. Commands should throw errors and allow them to be caught by the `catch` method in `BaseCommand`. There may be exceptions specifically around errors that are non-fatal. Thrown errors should be defined in either `ValidationErrors` or `ConfigurationErrors`.
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!--
Copyright 2019 Adobe. All rights reserved.
Copyright 2022 Adobe. All rights reserved.
This file is licensed to you under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License. You may obtain a copy
of the License at http://www.apache.org/licenses/LICENSE-2.0
Expand Down
4 changes: 3 additions & 1 deletion e2e/e2e.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
Copyright 2019 Adobe. All rights reserved.
Copyright 2022 Adobe. All rights reserved.
This file is licensed to you under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License. You may obtain a copy
of the License at http://www.apache.org/licenses/LICENSE-2.0
Expand Down Expand Up @@ -66,6 +66,8 @@ test('plugin-cloudmanager help test', async () => {
console.log(chalk.green(` - done for ${chalk.bold(name)}`))
})

/* Side condition: debug log output must not be enabled (DEBUG=* or LOG_LEVEL=debug),
or else the result in result.stdout is not valid JSON and cannot be parsed (line: JSON.parse...) */
test('plugin-cloudmanager list-programs', async () => {
await bootstrapAuthContext()
const packagejson = JSON.parse(fs.readFileSync('package.json').toString())
Expand Down
12 changes: 6 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
"author": "Adobe Inc.",
"bugs": "https://github.com/adobe/aio-cli-plugin-cloudmanager/issues",
"dependencies": {
"@adobe/aio-lib-cloudmanager": "^2.0.0",
"@adobe/aio-lib-core-config": "^2.0.0",
"@adobe/aio-lib-core-errors": "^3.0.1",
"@adobe/aio-lib-core-logging": "^1.2.0",
"@adobe/aio-lib-core-networking": "^2.0.0",
"@adobe/aio-lib-ims": "^5.0.0",
"@adobe/aio-lib-cloudmanager": "^3.0.0",
"@adobe/aio-lib-core-config": "^3.0.0",
"@adobe/aio-lib-core-errors": "^3.1.1",
"@adobe/aio-lib-core-logging": "^2.0.0",
"@adobe/aio-lib-core-networking": "^3.0.0",
"@adobe/aio-lib-ims": "^6.0.1",
"@oclif/command": "^1.6.1",
"@oclif/config": "^1.15.1",
"@oclif/parser": "^3.8.5",
Expand Down