Skip to content

Conversation

@zygw
Copy link
Contributor

@zygw zygw commented May 2, 2023

Description

Added commands dealing with content set/content flow

For content flow added: list, create, cancel, get
For content set added list, get, delete

Related Issue

Motivation and Context

Allow users to have CLI access to content flow and content set information and be able to create/cancel content flows.

How Has This Been Tested?

Unit test created
Each command was tested by executing it against a stage setup containing programs, environments and existing content sets/flows

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zygw zygw force-pushed the ContentSet branch 2 times, most recently from 8c3a08f to 914eb0a Compare May 3, 2023 11:16
…ents adobe#670

content flow list,create,cancel,get
content set list,get,delete
Updated to get topics displayed correctly
Stubbed out the list-programs e2e test since it can't be run by the bot (requires setup)
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #669 (3c3d804) into main (2b286c6) will decrease coverage by 0.33%.
The diff coverage is 96.57%.

@@             Coverage Diff             @@
##              main     #669      +/-   ##
===========================================
- Coverage   100.00%   99.67%   -0.33%     
===========================================
  Files           57       64       +7     
  Lines         1390     1536     +146     
  Branches       203      214      +11     
===========================================
+ Hits          1390     1531     +141     
- Misses           0        5       +5     
Impacted Files Coverage Δ
src/commands/cloudmanager/content-flow/get.js 91.66% <91.66%> (ø)
src/commands/cloudmanager/content-set/get.js 91.66% <91.66%> (ø)
...commands/cloudmanager/program/list-content-sets.js 94.73% <94.73%> (ø)
src/commands/cloudmanager/content-flow/cancel.js 100.00% <100.00%> (ø)
src/commands/cloudmanager/content-flow/create.js 100.00% <100.00%> (ø)
src/commands/cloudmanager/content-set/delete.js 100.00% <100.00%> (ø)
...ommands/cloudmanager/program/list-content-flows.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@weaverjas weaverjas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

@weaverjas weaverjas merged commit 95836ed into adobe:main May 15, 2023
@github-actions
Copy link

🎉 This PR is included in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants