added voiceEnabled option to sendConversationEvent in Brand Concierge component#1457
Open
MasonPinZ wants to merge 3 commits intoadobe:mainfrom
Open
added voiceEnabled option to sendConversationEvent in Brand Concierge component#1457MasonPinZ wants to merge 3 commits intoadobe:mainfrom
MasonPinZ wants to merge 3 commits intoadobe:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 87e5c74 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
b101cfe to
4f91ca4
Compare
Author
|
@carterworks , @ninaceban , this is the new PR of adding |
4 tasks
carterworks
requested changes
Mar 11, 2026
packages/core/test/unit/specs/components/BrandConcierge/createSendConversationEvent.spec.js
Show resolved
Hide resolved
Collaborator
|
Don't worry about the sonarqube report action failing - it is unreleated. |
Member
|
@MasonPinZ You latest commits cannot be merged because there is a conflict in |
carterworks
approved these changes
Mar 13, 2026
Collaborator
carterworks
left a comment
There was a problem hiding this comment.
Resolve the merge conflicts and then we're good to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
voiceEnabledboolean option to thesendConversationEventcommand, allowing callers to route requests to the voice subpath (/brand-concierge-voice) on a per-call basis.voiceEnabledisfalse(default), requests continue to use the existing/brand-conciergesubpath — fully backwards compatible.validateMessage.jsfor bothmessage-based anddata-based option shapes.Usage example
Related Issue
BRANDCON-3982
Motivation and Context
Screenshots (if appropriate):
Checklist:
pnpm changeset) or it is not necessary because this PR is not consumer-facing.