fixed - duplicates of metas in notification call

[ninaceban]

Description

If we have a decision with multiple items we should have only one insert in the personalization.decisions array

{
  "decisions": [
    {
      "id": "TNT:113866:1"
    },
    {
      "id": "TNT:115166:0"
    },
    {
      "id": "TNT:113712:1"
    }
  ]
}

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Improvement (non-breaking change which does not add functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have signed the Adobe Open Source CLA or I'm an Adobe employee.
• I have made any necessary test changes and all tests pass.
• I have run the Sandbox successfully.

[Aaronius]

This should probably be extracted to a utility. Here's my thought:

// identity.js
const identity = value => value;

// dedupe.js
const dedupe = (items, keyResolver = identity) => {
  const set = new Set();
  return items.filter(item => {
    const key = keyResolver(item);
    if (set.has(key)) {
      return false;
    }

    set.add(key);
    return true;
  });
};

Example usage:

const dedupedMetas = dedupe(metas, meta => meta.id);

[Aaronius]

I'm a little confused by the metas naming, because I would expect each item in metas to be a meta, but it seems like it's an object with a meta property. This might be something to improve is something comes to mind for you.

[ninaceban]

@Aaronius could you please take a look again, I have made some other changes. We need to skip some results that contain errors from metas. We will discuss this later if we should send this data to konductor.

[jfkhoury]

Will this cause issues in IE11?

[ninaceban]

nope - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set

[jfkhoury]

Looks good, other than the Set comment I added. 👍