Skip to content

Functional test for command queueing#485

Merged
liljenback merged 1 commit intomasterfrom
CORE-38950
May 6, 2020
Merged

Functional test for command queueing#485
liljenback merged 1 commit intomasterfrom
CORE-38950

Conversation

@liljenback
Copy link
Contributor

Description

Functional test to ensure that commands are queued up before alloy library is loaded and then executes after library has finished loading.

Related Issue

CORE-38950

Motivation and Context

Make sure we validate that library will capture all commands if library is slow to load.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

@liljenback liljenback requested review from jfkhoury and owenleej May 6, 2020 03:49
Copy link
Contributor

@jfkhoury jfkhoury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creative!!

Copy link
Contributor

@owenleej owenleej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@liljenback liljenback merged commit 67d9bd0 into master May 6, 2020
@liljenback liljenback deleted the CORE-38950 branch May 6, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants