Conversation
liljenback
reviewed
May 6, 2020
test/functional/specs/C148846.js
Outdated
| // Expects the CNAME request header to contain the Konductor state cookies. | ||
| // Expects the CNAME response body to not contain the Konductor state. | ||
| // Expects the CNAME response header to contain the Konductor state. | ||
| await assertCnameUseCases(secondRequest, cnameStateHandle); |
Contributor
There was a problem hiding this comment.
Perhaps move this out of the if-else because it is the same for both and keep the comments
liljenback
approved these changes
May 6, 2020
Aaronius
reviewed
May 7, 2020
test/functional/specs/C148846.js
Outdated
| const identityCookieName = "kndctr_334F60F35E1597910A495EC2_AdobeOrg_identity"; | ||
|
|
||
| const areThirdPartyCookiesSupportedByBrowserByDefault = () => | ||
| browsersSupportingThirdPartyCookiesByDefault.indexOf(t.browser.name) !== -1; |
Contributor
There was a problem hiding this comment.
It might be worth moving this (and the list of browsers) into a helper, since it's also used in another test and potentially future tests.
Contributor
Author
There was a problem hiding this comment.
Good idea, will do.
Aaronius
approved these changes
May 7, 2020
jfkhoury
commented
May 7, 2020
test/functional/specs/C148846.js
Outdated
|
|
||
| const identityCookieName = "kndctr_334F60F35E1597910A495EC2_AdobeOrg_identity"; | ||
|
|
||
| const areThirdPartyCookiesSupportedByBrowserByDefault = () => |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Checklist: