Skip to content

Add "dom-action" schema only if PAGE_WIDE_SCOPE decisions are requested#594

Merged
ninaceban merged 2 commits intomasterfrom
TNT-37827
Sep 11, 2020
Merged

Add "dom-action" schema only if PAGE_WIDE_SCOPE decisions are requested#594
ninaceban merged 2 commits intomasterfrom
TNT-37827

Conversation

@ninaceban
Copy link
Contributor

Description

Personalization component should be sending "dom-action" schema ONLY when sendEvent(...) renderDecisions is set to true.

Related Issue

None

Motivation and Context

We should not send "dom-action" schema if whoever implements Alloy doesn't want decisions to be auto-rendered. This should also help the backend be a little bit more selective about the data it processes and returns.

Screenshots (if appropriate):

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

@@ -17,3 +17,4 @@ export const JSON_CONTENT_ITEM =
"https://ns.adobe.com/personalization/json-content-item";
export const REDIRECT_ITEM =
"https://ns.adobe.com/personalization/redirect-item";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A filename like personalizationConstants.js suggests that the focus of this file might not be narrow enough, especially since it's located under Personalization/constants. Rather than a bucket of all potential personalization constants, would it make more sense to have schema.js and scope.js files instead? Another thing to note is that personalizationConstants.js is plural whereas our convention is that the file should be singular (https://github.com/adobe/alloy/wiki/Conventions#enumerations).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, will extract those in separate files

@jonsnyder
Copy link
Collaborator

The title of this PR is a bit misleading. Its really doing: Add "Dom-action" schema only if page wide scope is requested explicitly
or implicitly by setting renderDecisions = true.

@ninaceban ninaceban changed the title Add "dom-action" schema only if render decisions is true. Add "dom-action" schema only if PAGE_WIDE_SCOPE decisions are requested Sep 11, 2020
@ninaceban ninaceban merged commit 4f3ab47 into master Sep 11, 2020
@ninaceban ninaceban deleted the TNT-37827 branch September 11, 2020 21:46
Spencer-Smith pushed a commit that referenced this pull request Feb 20, 2026
…s enabled (#594)

* Show advertising settings in the send event view  when the component is enabled.

* Skip for the moment

* Fix the view rendering.

* Fix the rendering.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants