Conversation
| @@ -17,3 +17,4 @@ export const JSON_CONTENT_ITEM = | |||
| "https://ns.adobe.com/personalization/json-content-item"; | |||
| export const REDIRECT_ITEM = | |||
| "https://ns.adobe.com/personalization/redirect-item"; | |||
There was a problem hiding this comment.
A filename like personalizationConstants.js suggests that the focus of this file might not be narrow enough, especially since it's located under Personalization/constants. Rather than a bucket of all potential personalization constants, would it make more sense to have schema.js and scope.js files instead? Another thing to note is that personalizationConstants.js is plural whereas our convention is that the file should be singular (https://github.com/adobe/alloy/wiki/Conventions#enumerations).
There was a problem hiding this comment.
thank you, will extract those in separate files
|
The title of this PR is a bit misleading. Its really doing: Add "Dom-action" schema only if page wide scope is requested explicitly |
…s enabled (#594) * Show advertising settings in the send event view when the component is enabled. * Skip for the moment * Fix the view rendering. * Fix the rendering.
Description
Personalization component should be sending "dom-action" schema ONLY when
sendEvent(...)renderDecisionsis set totrue.Related Issue
None
Motivation and Context
We should not send "dom-action" schema if whoever implements Alloy doesn't want decisions to be auto-rendered. This should also help the backend be a little bit more selective about the data it processes and returns.
Screenshots (if appropriate):
None
Types of changes
Checklist: