This repository was archived by the owner on Sep 2, 2021. It is now read-only.
Fix remove menu performance on Windows #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Contributor
|
@lkcampbell Please have a look at this and feel free to merge at your convenience. |
appshell/appshell_extensions_win.cpp
Outdated
Contributor
There was a problem hiding this comment.
You moved the comment from the bottom of SetMenuTitle() to just above ScheduleMenuRedraw(). This comment should reflect that change.
Contributor
|
@redmunds, initial code review done. Looks good, just one nit on comments. Good idea refactoring the older stable code. |
Contributor
Author
|
Changes pushed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes menu drawing performance for
RemoveMenu()andRemoveMenuItem()in the same way that pull request #377 fixed it forAddMenu().I noticed this issue when reviewing pull request adobe/brackets#6334.