Conversation
updates/stable/en.json
Outdated
There was a problem hiding this comment.
Typo: "Upgradable"... though I wonder if that's clear enough. Maybe something like "Install Updates in Place"?
There was a problem hiding this comment.
Btw @bchintx did we ever write up documentation for how to have two versions installed at once, if needed for testing? (I'd thought that was one of the story tasks, but looks like I was wrong)
There was a problem hiding this comment.
"in-place" seems maybe a bit technical? Upgrade Brackets Installation?
There was a problem hiding this comment.
@peterflynn Good observation. No, I haven't documented that anywhere, but I can definitely do so. Any suggestions on where to add those steps?
There was a problem hiding this comment.
@bchintx Maybe just the release notes for now? Could add it to the "UI Changes" section that already mentions upgrade-in-place...
|
@jasonsanjose Done reviewing -- just a few suggestions. |
updates/stable/en.json
Outdated
There was a problem hiding this comment.
Should probably replace "restarted" with "relaunched" to match terminology used by dialog.
|
@peterflynn changes pushed. |
updates/stable/en.json
Outdated
There was a problem hiding this comment.
@jasonsanjose This still seems like it might not be super explanatory to users. What about "Upgrade Existing Brackets Installations"?
|
@peterflynn one more time :) |
|
Looks good -- merging |
|
@jbalsas @TomMalbran The en updates for Sprint 34 are complete, so you can start translating for es. |
|
Drive-by: "effecient" should be "efficient" |
|
@redmunds was just doing that ;) |
There was a problem hiding this comment.
Unless I missed it, Romanian is not yet merged, is it? (adobe/brackets#5836).
If we think it'll get done, it should go into the new translations.
There was a problem hiding this comment.
Oops... actually that one's assigned to me... how did that happen? :D
I'll take care to see if that's ready to merge. Sorry about that!
There was a problem hiding this comment.
@jasonsanjose It looks like the Romanian PR would actually be a brand-new language though -- so shouldn't it be listed in the first sentence instead of the second? (Although this also makes me think... if the number of items in the first sentence changes due to some PRs not landing, it may be difficult to change without retranslating -- lists of length 1 and/or 2 can be special cases grammatically in some languages).
There was a problem hiding this comment.
I'll get both strings translated with and without romanian. Since it's after hours and the translations may begin tonight, I'll do this immediately on master.
|
@jasonsanjose |
7 participants
No description provided.