Hard to quit Brackets if file with unsaved changes has been deleted/renamed on disk

[mikechambers]

See comment below for detailed repro steps

---

Working on a JavaScript file, and tried to save it. Get the following error:

An error occured when trying to open the file

c:/Users/mesh/src/SpectralKitten/src/www/js/main.js (error 2)

Click OK to dismiss error. Try to close the browser, I am prompted to save file, click yes, get error, click cancel, brackets doesnt close.

I eventually was able to get to a point where I could close brackets (somehow the file ended up closing).

Windows 7
Brackets version 0.1
Pull the build from source on April 25th (I cant find the exact commit).

[njx]

Adding medium priority. There are two problems here: the error itself, and then the fact that you can't quit.

[njx]

Recommending for sprint 8

[peterflynn]

I'll take a look at this

[peterflynn]

I sent an email to Mike requesting more info. I'm not sure how to repro the error in saving (or even if that part was unexpected, i.e. part of the bug). Fwiw, error code #2 is SECURITY_ERR.

Second, when I artificially set up a save error (e.g. by marking file read only), quitting still works as expected: if I hit Cancel I don't quit; if I hit Don't Save I do quit; if I hit Save it get an error message and don't quit. I'm not sure whether Mike saw a different dialog, saw this dialog but it behaved incorrectly, or simply found the current behavior confusing.

[mikechambers]

Sorry for the delayed response (I have been in transit today).

I havent been able to reproduce this since I ran into it.

mike

On Tue, May 1, 2012 at 2:35 PM, Peter Flynn
reply@reply.github.com
wrote:

I sent an email to Mike requesting more info.  I'm not sure how to repro the error in saving (or even if that part was unexpected, i.e. part of the bug).  Fwiw, error code #2 is SECURITY_ERR.

Second, when I artificially set up a save error (e.g. by marking file read only), quitting still works as expected: if I hit Cancel I don't quit; if I hit Don't Save I do quit; if I hit Save it get an error message and don't quit.  I'm not sure whether Mike saw a different dialog, saw this dialog but it behaved incorrectly, or simply found the current behavior confusing.

---

Reply to this email directly or view it on GitHub:
#755 (comment)

[peterflynn]

Ok, here are steps that may describe the issue:

1. Make edits in a file -- don't save
2. On disk, delete or rename the file
3. Return to Brackets; choose "Keep Changes in Editor"
4. Try to quit Brackets
5. In the unsaved changes confirmation, choose Don't Save -- this should drop the unsaved changes and proceed to quit

Result: you get an "Error opening file" popup, and then Brackets does not quit.

Workaround: close that one file, choose Don't Save, then quit Brackets
Or, if you don't care about keeping your changes, don't answer "Keep Changes" in step 3 :-)

[peterflynn]

Pretty sure that's what Mike was seeing. Clarifying title.

[peterflynn]

FBNC @mikechambers -- Mike, if this resolution feels good to you, can you go ahead & close it?

[mikechambers]

Looks good. Thanks for fixing.