This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
Adding infobar for remote debugging enabled #14956
Merged
shubhsnov
merged 7 commits into
adobe:master
from
g-217:jha-g/adding-infobar-for-remote-debugging
Nov 11, 2019
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
03d683d
Adding infobar for remote debugging enabled
g-217 41c851a
Changing infobar type to warning
g-217 2bdc286
Removed button related codes
g-217 c977dfe
infobar is an independent unit
g-217 8677756
Changed getRemoteDebuggingPort usage
g-217 29c08d2
Addressing review comments
g-217 a05057d
Updating infobar message
g-217 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <div id="info-bar-template" {{#type}}class={{{type}}}{{/type}} tabindex="0"> | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please test |
||
| <div id="icon-container"> | ||
| <svg id="info-icon"> </svg> | ||
| </div> | ||
| <div id="content-container"> | ||
| <p id="info-content"><span id="heading">{{title}}</span> <span id="description">{{{description}}}</span></p> | ||
| </div> | ||
| {{^buttons}} | ||
| <div id="close-icon-container"> | ||
| <button type="button" id="close-icon" tabIndex="0">×</button> | ||
| </div> | ||
| {{/buttons}} | ||
| </div> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,3 +57,5 @@ | |
|
|
||
| // Styling for scrollbars | ||
| @import url("brackets_scrollbars.less"); | ||
|
|
||
| @import url("infobar-styles.less"); | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,158 @@ | ||
| /* | ||
| * Copyright (c) 2019 - present Adobe Systems Incorporated. All rights reserved. | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person obtaining a | ||
| * copy of this software and associated documentation files (the "Software"), | ||
| * to deal in the Software without restriction, including without limitation | ||
| * the rights to use, copy, modify, merge, publish, distribute, sublicense, | ||
| * and/or sell copies of the Software, and to permit persons to whom the | ||
| * Software is furnished to do so, subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included in | ||
| * all copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING | ||
| * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER | ||
| * DEALINGS IN THE SOFTWARE. | ||
| * | ||
| */ | ||
|
|
||
| /*info Bar*/ | ||
| #info-bar-template { | ||
| display: block; | ||
| background-color: #105F9C; | ||
|
Comment on lines
+1
to
+27
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There are few unused selectors. Please clean them up.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Cleaned unused selectors. |
||
| box-shadow: 0px 3px 6px rgba(0, 0, 0, 0.53); | ||
| height: 38px; | ||
| width: 100%; | ||
| position: absolute; | ||
| z-index: 15; | ||
| left: 0px; | ||
| bottom: 25px; | ||
| outline: none; | ||
| overflow: hidden; | ||
| } | ||
|
|
||
| #info-bar-template #icon-container { | ||
| width: auto; | ||
| height: auto; | ||
| padding: 11px; | ||
| float: left; | ||
| } | ||
| #info-bar-template #icon-container #info-icon { | ||
| background: url("images/infobar-info.svg") no-repeat 0 0; | ||
| width: 16px; | ||
| height: 16px; | ||
| display: block; | ||
| } | ||
|
|
||
| #info-bar-template #content-container { | ||
| padding: 10px 7px; | ||
| float: left; | ||
| max-width: 78%; | ||
| } | ||
|
|
||
| #info-bar-template #content-container #info-content { | ||
| margin: 0px !important; /*Check if this important is necessary*/ | ||
| line-height: 18px; | ||
| font-size: 14px; | ||
| font-family: 'SourceSansPro'; | ||
| color: #FFFFFF; | ||
| overflow: hidden; | ||
| text-overflow: ellipsis; | ||
| white-space: nowrap; | ||
| } | ||
|
|
||
| #info-bar-template #content-container #info-content #heading{ | ||
| font-weight: bold; | ||
| } | ||
| /*For focussed link of brackets.io*/ | ||
| #info-bar-template #content-container #info-content #description a:focus{ | ||
| box-shadow: none; | ||
| } | ||
|
|
||
| #info-bar-template #content-container #info-content #description a{ | ||
| text-decoration: underline; | ||
| color: #FFFFFF; | ||
| } | ||
|
|
||
| #info-bar-template #close-icon-container { | ||
| height: auto; | ||
| padding: 9px; | ||
| position: fixed; | ||
| float: right; | ||
| text-align: center; | ||
| width: auto; | ||
| min-width: 66px; | ||
| right: 30px; | ||
| background-color: #105F9C; | ||
| } | ||
|
|
||
| #info-bar-template #close-icon-container #close-icon { | ||
| display: block; | ||
| color: white; | ||
| font-size: 18px; | ||
| line-height: 18px; | ||
| text-decoration: none; | ||
| width: 18px; | ||
| height: 18px; | ||
| background-color: transparent; | ||
| border: none; | ||
| padding: 0px; /*This is needed to center the icon*/ | ||
| float: right; | ||
| } | ||
|
|
||
| #info-bar-template #close-icon-container #close-icon:hover { | ||
| background-color: rgba(255, 255, 255 ,0.16); | ||
| border-radius: 50%; | ||
| } | ||
|
|
||
| #info-bar-template #close-icon-container #close-icon:focus { | ||
| background-color: rgba(255, 255, 255 ,0.16); | ||
| border-radius: 50%; | ||
| border: 1px solid #C3E3FF; | ||
| outline: 0; | ||
| } | ||
|
|
||
| #info-bar-template #close-icon-container #close-icon:focus:active { | ||
| background-color: rgba(255, 255, 255 ,0.32); | ||
| border: none; | ||
| } | ||
|
|
||
| /*Warning Message in info Bar*/ | ||
| #info-bar-template.warning, #info-bar-template.warning #close-icon-container { | ||
| background-color: #DA7A12; | ||
| } | ||
|
|
||
| .dark #info-bar-template.warning, .dark #info-bar-template.warning #close-icon-container { | ||
| background-color: #E6851A; | ||
| } | ||
|
|
||
| #info-bar-template.warning #icon-container #info-icon, | ||
| #info-bar-template.error #icon-container #info-icon { | ||
| background: url("images/infobar-alert.svg") no-repeat 0 0; | ||
| } | ||
|
|
||
| /*Error message in info Bar*/ | ||
| #info-bar-template.error, #info-bar-template.error #close-icon-container { | ||
| background-color: #D7373F; | ||
| } | ||
|
|
||
| .dark #info-bar-template.error, .dark #info-bar-template.error #close-icon-container{ | ||
| background-color: #E4484F; | ||
| } | ||
| /*Success message in info Bar*/ | ||
| #info-bar-template.success, #info-bar-template.success #close-icon-container { | ||
| background-color: #278E6B; | ||
| } | ||
|
|
||
| .dark #info-bar-template.success, .dark #info-bar-template.success #close-icon-container { | ||
| background-color: #2E9D77; | ||
| } | ||
|
|
||
| #info-bar-template.success #icon-container #info-icon{ | ||
| background: url("images/infobar-checkmarkcircle.svg") no-repeat 0 0; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious as to why they check for function definition here? Do we lazyload some modules?