This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Incremental search while typing in the Find bar#1781
Merged
Conversation
Although highlighting matches is turned off in our CSS, the changes here were tested & should work when/if highlights are made visible again. Also includes some docs improvements.
Contributor
|
Very cool! I notice a couple usability quirks with this:
|
Contributor
|
Done with initial review. |
Member
Author
|
Contributor
|
Looks good. Merging. |
redmunds
added a commit
that referenced
this pull request
Oct 12, 2012
Incremental search while typing in the Find bar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the Find (within file) feature so the first matching result is highlighted as you type, instead of after you press Enter. Navigating to subsequent/previous results still works the same as before.
Although highlighting all matches (mark occurrences) is turned off in our CSS, the changes here were tested & should work when/if highlights are made visible again.
Also includes some docs improvements.